netdev - Re: [PATCH net-next 08/12] net: homa: create homa

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGXJAmwD-o7s7dvRbWLACuzsPV_UEwHotg2rpy8aCHeGf5390w@mail.gmail.com>
Date: Wed, 30 Oct 2024 11:33:53 -0700
From: John Ousterhout <ouster@...stanford.edu>
To: Eric Dumazet <eric.dumazet@...il.com>
Cc: netdev@...r.kernel.org, edumazet@...gle.com
Subject: Re: [PATCH net-next 08/12] net: homa: create homa_incoming.c

On Wed, Oct 30, 2024 at 11:23 AM Eric Dumazet <eric.dumazet@...il.com> wrote:

> 1) kmalloc() can return NULL. This will crash your host.

Oops, that should have been checked. I will fix (and it looks like
there may be a few other places that need fixing also).

> 2) get_cycles() is not generally available, and can go backward anyway.
>
>    There is a reason it is not used at all in net.

It looks like sched_clock is the closest alternative (I need something
that is fine-grain and efficient)? I will switch to that unless
advised otherwise.

Thanks for the comments.

-John-