netdev - Re: [PATCH net 0/2] Get the device_node before calling of_find_node_by

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241030181709.24ae5efb@kernel.org>
Date: Wed, 30 Oct 2024 18:17:09 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Zhang Zekun <zhangzekun11@...wei.com>
Cc: <justin.chen@...adcom.com>, <florian.fainelli@...adcom.com>,
 <andrew+netdev@...n.ch>, <davem@...emloft.net>, <o.rempel@...gutronix.de>,
 <kory.maincent@...tlin.com>, <horms@...nel.org>, <edumazet@...gle.com>,
 <pabeni@...hat.com>, <netdev@...r.kernel.org>, <chenjun102@...wei.com>
Subject: Re: [PATCH net 0/2] Get the device_node before calling
 of_find_node_by_name()

On Thu, 24 Oct 2024 09:59:07 +0800 Zhang Zekun wrote:
> of_find_node_by_name() will decrease the refount of the device node.
> Get the device_node before call to it.

Doing some quick grepping I think Andrew is completely right.
Most callers either get this wrong or call get() immediately prior.
Maybe add a new helper with more suitable semantics?

The goal is not to fix the bugs but to prevent them in the first place.
-- 
pw-bot: cr