netdev - Re: [PATCH net-next] net: dsa: mt7530: Add TBF qdisc offload support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZyOR-w_KtIXk0ug6@lore-desk>
Date: Thu, 31 Oct 2024 15:19:39 +0100
From: Lorenzo Bianconi <lorenzo@...nel.org>
To: Arınç ÜNAL <arinc.unal@...nc9.com>
Cc: Daniel Golle <daniel@...rotopia.org>, DENG Qingfang <dqfext@...il.com>,
	Sean Wang <sean.wang@...iatek.com>, Andrew Lunn <andrew@...n.ch>,
	Florian Fainelli <f.fainelli@...il.com>,
	Vladimir Oltean <olteanv@...il.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Matthias Brugger <matthias.bgg@...il.com>,
	AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
	netdev@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH net-next] net: dsa: mt7530: Add TBF qdisc offload support

> On 31/10/2024 11:00, Lorenzo Bianconi wrote:
> > > On 30/10/2024 22:29, Lorenzo Bianconi wrote:
> > > > Introduce port_setup_tc callback in mt7530 dsa driver in order to enable
> > > > dsa ports rate shaping via hw Token Bucket Filter (TBF) for hw switched
> > > > traffic. Enable hw TBF just for EN7581 SoC for the moment.
> > > 
> > > Is this because you didn't test it on the other models? Let me know if
> > > that's the case and I'll test it.
> > 
> > yep, exactly. I have tested it just on EN7581 since I do not have any other
> > boards for testing at the moment. If you confirm it works on other SoCs too,
> > I can remove the limitation.
> 
> Seems to be working fine on MT7530. As we have tested this on the oldest
> and newest models that use this switching IP, I'm going to assume it will
> work on the other models as well. You can remove the limitation. Also,
> please change MT7530_ERLCR_P and MT7530_GERLCR to MT753X_ERLCR_P and
> MT753X_GERLCR.

ack, thx for testing. I will fix it in v2.

Regards,
Lorenzo

> 
> tc qdisc add dev lan4 root tbf rate 10mbit burst 10kb latency 50ms
> 
> [ ID] Interval           Transfer     Bitrate         Retr
> [  5]   0.00-5.00   sec  5.88 MBytes  9.85 Mbits/sec    4             sender
> [  5]   0.00-5.00   sec  5.50 MBytes  9.23 Mbits/sec                  receiver
> 
> tc qdisc del dev lan4 root
> 
> [ ID] Interval           Transfer     Bitrate         Retr
> [  5]   0.00-5.00   sec   469 MBytes   786 Mbits/sec    0             sender
> [  5]   0.00-5.00   sec   468 MBytes   785 Mbits/sec                  receiver
> 
> tc qdisc add dev lan4 root tbf rate 11mbit burst 10kb latency 50ms
> 
> [ ID] Interval           Transfer     Bitrate         Retr
> [  5]   0.00-5.00   sec  6.38 MBytes  10.7 Mbits/sec    6             sender
> [  5]   0.00-5.00   sec  6.00 MBytes  10.1 Mbits/sec                  receiver
> 
> tc qdisc del dev lan4 root
> 
> [ ID] Interval           Transfer     Bitrate         Retr
> [  5]   0.00-5.00   sec   467 MBytes   783 Mbits/sec    0             sender
> [  5]   0.00-5.00   sec   466 MBytes   783 Mbits/sec                  receiver
> 
> tc qdisc add dev lan4 root tbf rate 11mbit burst 10kb latency 50ms
> tc qdisc replace dev lan4 root tbf rate 10mbit burst 10kb latency 50ms
> 
> [ ID] Interval           Transfer     Bitrate         Retr
> [  5]   0.00-5.00   sec  5.88 MBytes  9.85 Mbits/sec    4             sender
> [  5]   0.00-5.00   sec  5.50 MBytes  9.23 Mbits/sec                  receiver
> 
> Arınç

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)