netdev - RE: [PATCH net-next v2 11/13] ice: enable FDIR filters from raw binary patterns for VFs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CO1PR11MB5089AFECEC0354C0B38BEF2BD6552@CO1PR11MB5089.namprd11.prod.outlook.com>
Date: Thu, 31 Oct 2024 16:18:11 +0000
From: "Keller, Jacob E" <jacob.e.keller@...el.com>
To: "Guo, Junfeng" <junfeng.guo@...el.com>, "Nguyen, Anthony L"
	<anthony.l.nguyen@...el.com>, "davem@...emloft.net" <davem@...emloft.net>,
	"kuba@...nel.org" <kuba@...nel.org>, "pabeni@...hat.com" <pabeni@...hat.com>,
	"edumazet@...gle.com" <edumazet@...gle.com>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "Zaki, Ahmed" <ahmed.zaki@...el.com>, "Chittim,
 Madhu" <madhu.chittim@...el.com>
CC: "horms@...nel.org" <horms@...nel.org>, "hkelam@...vell.com"
	<hkelam@...vell.com>, Marcin Szycik <marcin.szycik@...ux.intel.com>,
	"Romanowski, Rafal" <rafal.romanowski@...el.com>
Subject: RE: [PATCH net-next v2 11/13] ice: enable FDIR filters from raw
 binary patterns for VFs



> -----Original Message-----
> From: Guo, Junfeng <junfeng.guo@...el.com>
> Sent: Thursday, October 31, 2024 12:38 AM
> To: Keller, Jacob E <jacob.e.keller@...el.com>; Nguyen, Anthony L
> <anthony.l.nguyen@...el.com>; davem@...emloft.net; kuba@...nel.org;
> pabeni@...hat.com; edumazet@...gle.com; netdev@...r.kernel.org; Zaki,
> Ahmed <ahmed.zaki@...el.com>; Chittim, Madhu <madhu.chittim@...el.com>
> Cc: horms@...nel.org; hkelam@...vell.com; Marcin Szycik
> <marcin.szycik@...ux.intel.com>; Romanowski, Rafal
> <rafal.romanowski@...el.com>
> Subject: RE: [PATCH net-next v2 11/13] ice: enable FDIR filters from raw binary
> patterns for VFs
> 
> Hi Jake,
> 
> Thanks for pointing this out with your carefully review!
> 
> And yes, you are correct.
> The implementation of fdir_prof_info as a table may waste a lot of memory.
> It would be better to use a linked list instead to save memory.
> And the logic of store/find/delete profile info should be modified accordingly.
> 
> Unfortunately, I'm not able to working on the improvement now. : (
> Hi @Chittim, Madhu and @Zaki, Ahmed, could you help consider about how to
> improve the code?
> Thanks a lot!
> 
> Regards,
> Junfeng

I may take a crack at converting this to an xarray, since its already a normal C array, the transition might be easier than doing it via linked list. Xarray has nice properties for random access.

Thanks,
Jake