netdev - Re: [resend PATCH 2/2] dim: pass dim_sample to net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241031164823.k6gqr6hm7ukd4dt6@skbuf>
Date: Thu, 31 Oct 2024 18:48:23 +0200
From: Vladimir Oltean <vladimir.oltean@....com>
To: Caleb Sander Mateos <csander@...estorage.com>
Cc: Andrew Lunn <andrew+netdev@...n.ch>,
	AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
	Arthur Kiyanovski <akiyano@...zon.com>,
	Brett Creeley <brett.creeley@....com>,
	Broadcom internal kernel review list <bcm-kernel-feedback-list@...adcom.com>,
	Christophe Leroy <christophe.leroy@...roup.eu>,
	Claudiu Manoil <claudiu.manoil@....com>,
	David Arinzon <darinzon@...zon.com>,
	"David S. Miller" <davem@...emloft.net>,
	Doug Berger <opendmb@...il.com>, Eric Dumazet <edumazet@...gle.com>,
	Eugenio PÃ©rez <eperezma@...hat.com>,
	Felix Fietkau <nbd@....name>,
	Florian Fainelli <florian.fainelli@...adcom.com>,
	Geetha sowjanya <gakula@...vell.com>,
	hariprasad <hkelam@...vell.com>, Jakub Kicinski <kuba@...nel.org>,
	Jason Wang <jasowang@...hat.com>, Jonathan Corbet <corbet@....net>,
	Leon Romanovsky <leon@...nel.org>,
	Lorenzo Bianconi <lorenzo@...nel.org>,
	Louis Peens <louis.peens@...igine.com>,
	Mark Lee <Mark-MC.Lee@...iatek.com>,
	Matthias Brugger <matthias.bgg@...il.com>,
	Michael Chan <michael.chan@...adcom.com>,
	"Michael S. Tsirkin" <mst@...hat.com>,
	Noam Dagan <ndagan@...zon.com>, Paolo Abeni <pabeni@...hat.com>,
	Przemek Kitszel <przemyslaw.kitszel@...el.com>,
	Roy Pledge <Roy.Pledge@....com>, Saeed Bishara <saeedb@...zon.com>,
	Saeed Mahameed <saeedm@...dia.com>,
	Sean Wang <sean.wang@...iatek.com>,
	Shannon Nelson <shannon.nelson@....com>,
	Shay Agroskin <shayagr@...zon.com>, Simon Horman <horms@...nel.org>,
	Subbaraya Sundeep <sbhatta@...vell.com>,
	Sunil Goutham <sgoutham@...vell.com>, Tal Gilboa <talgi@...dia.com>,
	Tariq Toukan <tariqt@...dia.com>,
	Tony Nguyen <anthony.l.nguyen@...el.com>,
	Xuan Zhuo <xuanzhuo@...ux.alibaba.com>,
	intel-wired-lan@...ts.osuosl.org,
	linux-arm-kernel@...ts.infradead.org, linux-doc@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-mediatek@...ts.infradead.org,
	linuxppc-dev@...ts.ozlabs.org, linux-rdma@...r.kernel.org,
	netdev@...r.kernel.org, oss-drivers@...igine.com,
	virtualization@...ts.linux.dev
Subject: Re: [resend PATCH 2/2] dim: pass dim_sample to net_dim() by reference

On Wed, Oct 30, 2024 at 06:23:26PM -0600, Caleb Sander Mateos wrote:
> net_dim() is currently passed a struct dim_sample argument by value.
> struct dim_sample is 24 bytes. Since this is greater 16 bytes, x86-64
> passes it on the stack. All callers have already initialized dim_sample
> on the stack, so passing it by value requires pushing a duplicated copy
> to the stack. Either witing to the stack and immediately reading it, or
> perhaps dereferencing addresses relative to the stack pointer in a chain
> of push instructions, seems to perform quite poorly.
> 
> In a heavy TCP workload, mlx5e_handle_rx_dim() consumes 3% of CPU time,
> 94% of which is attributed to the first push instruction to copy
> dim_sample on the stack for the call to net_dim():
> // Call ktime_get()
>   0.26 |4ead2:   call   4ead7 <mlx5e_handle_rx_dim+0x47>
> // Pass the address of struct dim in %rdi
>        |4ead7:   lea    0x3d0(%rbx),%rdi
> // Set dim_sample.pkt_ctr
>        |4eade:   mov    %r13d,0x8(%rsp)
> // Set dim_sample.byte_ctr
>        |4eae3:   mov    %r12d,0xc(%rsp)
> // Set dim_sample.event_ctr
>   0.15 |4eae8:   mov    %bp,0x10(%rsp)
> // Duplicate dim_sample on the stack
>  94.16 |4eaed:   push   0x10(%rsp)
>   2.79 |4eaf1:   push   0x10(%rsp)
>   0.07 |4eaf5:   push   %rax
> // Call net_dim()
>   0.21 |4eaf6:   call   4eafb <mlx5e_handle_rx_dim+0x6b>
> 
> To allow the caller to reuse the struct dim_sample already on the stack,
> pass the struct dim_sample by reference to net_dim().
> 
> Signed-off-by: Caleb Sander Mateos <csander@...estorage.com>
> ---

Reviewed-by: Vladimir Oltean <vladimir.oltean@....com>