netdev - Re: [PATCH net-next v4] net: Implement fault injection forcing skb reallocation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241101-macho-wolverine-of-glee-2ea606@leitao>
Date: Fri, 1 Nov 2024 02:55:47 -0700
From: Breno Leitao <leitao@...ian.org>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Jonathan Corbet <corbet@....net>, Akinobu Mita <akinobu.mita@...il.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
	Andrew Morton <akpm@...ux-foundation.org>, kernel-team@...a.com,
	Thomas Huth <thuth@...hat.com>,
	"Paul E. McKenney" <paulmck@...nel.org>,
	"Borislav Petkov (AMD)" <bp@...en8.de>,
	Steven Rostedt <rostedt@...dmis.org>,
	Xiongwei Song <xiongwei.song@...driver.com>,
	Mina Almasry <almasrymina@...gle.com>,
	Kuniyuki Iwashima <kuniyu@...zon.com>,
	Alexander Lobakin <aleksander.lobakin@...el.com>,
	Oleksij Rempel <o.rempel@...gutronix.de>,
	"open list:DOCUMENTATION" <linux-doc@...r.kernel.org>,
	open list <linux-kernel@...r.kernel.org>,
	"open list:NETWORKING [GENERAL]" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next v4] net: Implement fault injection forcing skb
 reallocation

Hello Jakub,

On Thu, Oct 31, 2024 at 05:04:28PM -0700, Jakub Kicinski wrote:
> > > the buffer needs to be null terminated, like:
> > > 
> > > skb_realloc.devname[IFNAMSIZ - 1] = '\0';
> > > 
> > > no?  
> > 
> > Yes, but isn't it what the next line do, with strim()?
> 
> I could be wrong, but looks like first thing strim does is call strlen()

makes sense. Let me send a v5 with the fixes, and we can continue from
there.

Thanks for the review!
--breno