netdev - Re: [PATCH net] net: enetc: prevent VF from configuring preemptiable TCs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241101115519.2a6ce6daqrzmhcfh@skbuf>
Date: Fri, 1 Nov 2024 13:55:19 +0200
From: Vladimir Oltean <vladimir.oltean@....com>
To: Wei Fang <wei.fang@....com>
Cc: "davem@...emloft.net" <davem@...emloft.net>,
	"edumazet@...gle.com" <edumazet@...gle.com>,
	"kuba@...nel.org" <kuba@...nel.org>,
	"pabeni@...hat.com" <pabeni@...hat.com>,
	"andrew+netdev@...n.ch" <andrew+netdev@...n.ch>,
	Claudiu Manoil <claudiu.manoil@....com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"imx@...ts.linux.dev" <imx@...ts.linux.dev>
Subject: Re: [PATCH net] net: enetc: prevent VF from configuring preemptiable
 TCs

On Thu, Oct 31, 2024 at 05:46:47AM +0200, Wei Fang wrote:
> > > Actually please do this instead:
> > >
> > > 	if (!(si->hw_features & ENETC_SI_F_QBU))
> > >
> 
> Actually, VFs of eno0 have ENETC_SI_F_QBU bit set. So we should use the
> following check instead.
> 
> if (!enetc_si_is_pf(si) || !(si->hw_features & ENETC_SI_F_QBU))
> 
> Or we only set ENETC_SI_F_QBU bit for PF in enetc_get_si_caps() if the PF
> supports 802.1 Qbu.

This one is weird. I don't know why the ENETC would push a capability in
the SI port capability register 0 for the VSI, if the VSI doesn't have
access to the port registers in the first place. Let me ask internally,
so we could figure out what's the best thing to do.