netdev - Re: code From d0f446931dfee7afa9f6ce5b1ac032e4dfa98460 Mon Sep 17 00:00:00 2001

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <38e4fc09-7c88-448b-b9e8-f9a082f1dcf0@lunn.ch>
Date: Fri, 1 Nov 2024 14:31:07 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Ley Foon Tan <leyfoon.tan@...rfivetech.com>
Cc: Alexandre Torgue <alexandre.torgue@...s.st.com>,
	Jose Abreu <joabreu@...opsys.com>,
	"David S . Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Maxime Coquelin <mcoquelin.stm32@...il.com>, netdev@...r.kernel.org,
	linux-stm32@...md-mailman.stormreply.com,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	lftan.linux@...il.com
Subject: Re: code From d0f446931dfee7afa9f6ce5b1ac032e4dfa98460 Mon Sep 17
 00:00:00 2001

On Fri, Nov 01, 2024 at 04:23:33PM +0800, Ley Foon Tan wrote:
> This patch series fixes the bugs in the dwmac4 drivers:
> 
> Patch #1: Fix incorrect _SHIFT and _MASK for MTL_OP_MODE_RTC_* macros.
> Patch #2: Fix bit mask off operation for MTL_OP_MODE_*_MASK.
> Patch #3: Fix Receive Watchdog Timeout (RWT) interrupt handling.
> 
> Changes since v1:
> - Updated CC list from get_maintainers.pl.
> - Removed Fixes tag.

It looks to me that the first two patches really are fixes? The last
patch is just a statistics counter, so probably not a fix?

If this is correct, please spit these into two series. The first two
should target net, and have Fixes: tags. The last patch should target
net-next, and does not need a Fixes: tag.

> - Add more description in cover letter.

The Subject: like of the cover letter could be better.

	Andrew