netdev - Re: [PATCH net-next v4 3/8] net: ethtool: add support for configuring header-data-split-thresh

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMArcTXAMezwF4gEQ6fE7sJAS2FPMonOVx7qm=8itYMD5Zv0ug@mail.gmail.com>
Date: Sat, 2 Nov 2024 03:50:09 +0900
From: Taehee Yoo <ap420073@...il.com>
To: Mina Almasry <almasrymina@...gle.com>
Cc: davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com, 
	edumazet@...gle.com, donald.hunter@...il.com, corbet@....net, 
	michael.chan@...adcom.com, andrew+netdev@...n.ch, hawk@...nel.org, 
	ilias.apalodimas@...aro.org, ast@...nel.org, daniel@...earbox.net, 
	john.fastabend@...il.com, dw@...idwei.uk, sdf@...ichev.me, 
	asml.silence@...il.com, brett.creeley@....com, linux-doc@...r.kernel.org, 
	netdev@...r.kernel.org, kory.maincent@...tlin.com, 
	maxime.chevallier@...tlin.com, danieller@...dia.com, hengqi@...ux.alibaba.com, 
	ecree.xilinx@...il.com, przemyslaw.kitszel@...el.com, hkallweit1@...il.com, 
	ahmed.zaki@...el.com, rrameshbabu@...dia.com, idosch@...dia.com, 
	jiri@...nulli.us, bigeasy@...utronix.de, lorenzo@...nel.org, 
	jdamato@...tly.com, aleksander.lobakin@...el.com, kaiyuanz@...gle.com, 
	willemb@...gle.com, daniel.zahka@...il.com
Subject: Re: [PATCH net-next v4 3/8] net: ethtool: add support for configuring header-data-split-thresh

On Fri, Nov 1, 2024 at 11:56 PM Mina Almasry <almasrymina@...gle.com> wrote:
>
> On Tue, Oct 22, 2024 at 9:24 AM Taehee Yoo <ap420073@...il.com> wrote:
> >
> > The header-data-split-thresh option configures the threshold value of
> > the header-data-split.
> > If a received packet size is larger than this threshold value, a packet
> > will be split into header and payload.
> > The header indicates TCP and UDP header, but it depends on driver spec.
> > The bnxt_en driver supports HDS(Header-Data-Split) configuration at
> > FW level, affecting TCP and UDP too.
> > So, If header-data-split-thresh is set, it affects UDP and TCP packets.
> >
> > Example:
> >    # ethtool -G <interface name> header-data-split-thresh <value>
> >
> >    # ethtool -G enp14s0f0np0 tcp-data-split on header-data-split-thresh 256
> >    # ethtool -g enp14s0f0np0
> >    Ring parameters for enp14s0f0np0:
> >    Pre-set maximums:
> >    ...
> >    Header data split thresh:  256
> >    Current hardware settings:
> >    ...
> >    TCP data split:         on
> >    Header data split thresh:  256
>
> This is a nit, feel free to ignore, but I wonder if we should call it
> 'Data split thresh' instead of 'Header data split threshold'.
>
> It was a bit weird for me to refer to the feature as tcp-data-split,
> but the threshold as hds_threshold which i guess is short for header
> split threshold. Aligning the names to 'TCP data split [threshold]'
> would be nice I think.

The reason why I used it is that I thought a command name and print
should be the same or very similar. Both "Data split thresh" and
"TCP data split threshold" are similar to the command.
But "Header data split thresh" is the same as the command. it's
very clear. So I still prefer "Header data split thresh".
But If you prefer these names, I will change it.

Thanks a lot!
Taehee Yoo

>
> --
> Thanks,
> Mina