lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <89955b74d225129d6e3d79b53aa8d81d1b50560f.camel@infradead.org>
Date: Sat, 02 Nov 2024 16:52:17 -0500
From: David Woodhouse <dwmw2@...radead.org>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Richard Cochran <richardcochran@...il.com>, Peter Hilber
 <peter.hilber@...nsynergy.com>, linux-kernel@...r.kernel.org, 
 virtualization@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org, 
 linux-rtc@...r.kernel.org, "Ridoux, Julien" <ridouxj@...zon.com>, 
 virtio-dev@...ts.linux.dev, "Luu, Ryan" <rluu@...zon.com>, "Chashper,
 David" <chashper@...zon.com>, "Mohamed Abuelfotoh, Hazem"
 <abuehaze@...zon.com>,  Paolo Abeni <pabeni@...hat.com>, "Christopher S .
 Hall" <christopher.s.hall@...el.com>, Jason Wang <jasowang@...hat.com>,
 John Stultz <jstultz@...gle.com>, "Michael S . Tsirkin" <mst@...hat.com>,
 netdev@...r.kernel.org, Stephen Boyd <sboyd@...nel.org>,  Thomas Gleixner
 <tglx@...utronix.de>, Xuan Zhuo <xuanzhuo@...ux.alibaba.com>, Marc Zyngier
 <maz@...nel.org>,  Mark Rutland <mark.rutland@....com>, Daniel Lezcano
 <daniel.lezcano@...aro.org>, Alessandro Zummo <a.zummo@...ertech.it>,
 Alexandre Belloni <alexandre.belloni@...tlin.com>,  qemu-devel
 <qemu-devel@...gnu.org>, Simon Horman <horms@...nel.org>
Subject: [PATCH net-next] ptp: Remove 'default y' for VMCLOCK PTP device

From: David Woodhouse <dwmw@...zon.co.uk>

The VMCLOCK device gives support for accurate timekeeping even across 
live migration, unlike the KVM PTP clock. To help ensure that users can
always use ptp_vmclock where it's available in preference to ptp_kvm,
set it to 'default PTP_1588_CLOCK_VMCLOCK' instead of 'default y'.

Signed-off-by: David Woodhouse <dwmw@...zon.co.uk>
---
 drivers/ptp/Kconfig | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/ptp/Kconfig b/drivers/ptp/Kconfig
index e98c9767e0ef..ed087ae75f0e 100644
--- a/drivers/ptp/Kconfig
+++ b/drivers/ptp/Kconfig
@@ -135,12 +135,16 @@ config PTP_1588_CLOCK_VMCLOCK
 	tristate "Virtual machine PTP clock"
 	depends on X86_TSC || ARM_ARCH_TIMER
 	depends on PTP_1588_CLOCK && ACPI && ARCH_SUPPORTS_INT128
-	default y
+	default PTP_1588_CLOCK_KVM
 	help
 	  This driver adds support for using a virtual precision clock
 	  advertised by the hypervisor. This clock is only useful in virtual
 	  machines where such a device is present.
 
+	  Unlike the KVM virtual PTP clock, the VMCLOCK device offers support
+	  for reliable timekeeping even across live migration. So this driver
+	  is enabled by default whenever the KVM PTP clock is.
+
 	  To compile this driver as a module, choose M here: the module
 	  will be called ptp_vmclock.
 
-- 
2.44.0



Download attachment "smime.p7s" of type "application/pkcs7-signature" (5965 bytes)

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ