netdev - Re: [PATCH net-next v4 2/7] net: Suspend softirq when prefer_busy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <af712da5-af87-4dce-84be-d6cc36de5bfe@intel.com>
Date: Sat, 2 Nov 2024 18:32:09 -0500
From: "Samudrala, Sridhar" <sridhar.samudrala@...el.com>
To: Joe Damato <jdamato@...tly.com>, <netdev@...r.kernel.org>
CC: <bagasdotme@...il.com>, <pabeni@...hat.com>, <namangulati@...gle.com>,
	<edumazet@...gle.com>, <amritha.nambiar@...el.com>, <sdf@...ichev.me>,
	<peter@...eblog.net>, <m2shafiei@...terloo.ca>, <bjorn@...osinc.com>,
	<hch@...radead.org>, <willy@...radead.org>,
	<willemdebruijn.kernel@...il.com>, <skhawaja@...gle.com>, <kuba@...nel.org>,
	Martin Karsten <mkarsten@...terloo.ca>, "David S. Miller"
	<davem@...emloft.net>, Simon Horman <horms@...nel.org>, David Ahern
	<dsahern@...nel.org>, Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
	Lorenzo Bianconi <lorenzo@...nel.org>, Alexander Lobakin
	<aleksander.lobakin@...el.com>, open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next v4 2/7] net: Suspend softirq when
 prefer_busy_poll is set



On 11/1/2024 7:51 PM, Joe Damato wrote:
> From: Martin Karsten <mkarsten@...terloo.ca>
> 
> When NAPI_F_PREFER_BUSY_POLL is set during busy_poll_stop and the
> irq_suspend_timeout is nonzero, this timeout is used to defer softirq
> scheduling, potentially longer than gro_flush_timeout. This can be used
> to effectively suspend softirq processing during the time it takes for
> an application to process data and return to the next busy-poll.
> 
> The call to napi->poll in busy_poll_stop might lead to an invocation of
> napi_complete_done, but the prefer-busy flag is still set at that time,
> so the same logic is used to defer softirq scheduling for
> irq_suspend_timeout.
> 
> Signed-off-by: Martin Karsten <mkarsten@...terloo.ca>
> Co-developed-by: Joe Damato <jdamato@...tly.com>
> Signed-off-by: Joe Damato <jdamato@...tly.com>
> Tested-by: Joe Damato <jdamato@...tly.com>
> Tested-by: Martin Karsten <mkarsten@...terloo.ca>
> Acked-by: Stanislav Fomichev <sdf@...ichev.me>
> ---

Reviewed-by: Sridhar Samudrala <sridhar.samudrala@...el.com>