netdev - Re: [PATCH v3 iwl-net 0/4] Fix E825 initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241102151236.GQ1838431@kernel.org>
Date: Sat, 2 Nov 2024 15:12:36 +0000
From: Simon Horman <horms@...nel.org>
To: Przemek Kitszel <przemyslaw.kitszel@...el.com>
Cc: Grzegorz Nitka <grzegorz.nitka@...el.com>, netdev@...r.kernel.org,
	anthony.l.nguyen@...el.com, intel-wired-lan@...ts.osuosl.org
Subject: Re: [PATCH v3 iwl-net 0/4] Fix E825 initialization

On Tue, Oct 29, 2024 at 09:33:32AM +0100, Przemek Kitszel wrote:
> On 10/28/24 21:45, Grzegorz Nitka wrote:
> > E825 products have incorrect initialization procedure, which may lead to
> > initialization failures and register values.
> > 
> > Fix E825 products initialization by adding correct sync delay, checking
> > the PHY revision only for current PHY and adding proper destination
> > device when reading port/quad.
> > 
> > In addition, E825 uses PF ID for indexing per PF registers and as
> > a primary PHY lane number, which is incorrect.
> > 
> > Karol Kolacinski (4):
> >    ice: Fix E825 initialization
> >    ice: Fix quad registers read on E825
> >    ice: Fix ETH56G FC-FEC Rx offset value
> >    ice: Add correct PHY lane assignment
> 
> Grzegorz, thank you for picking this series up!
> It is legally required that you sign-off too, but please wait for other
> feedback instead of rushing with re-send ;)

Likewise, thanks Grzegorz.

FWIIW, I've provided some feedback on patch 2/4.
And the rest of the series looks good to me.