netdev - Re: [PATCH net-next 12/12] net: homa: create Makefile and Kconfig

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAGXJAmxRoU8tkxC+wX24Zn8vvh16ih7d8d83DwOt1h_gPVy62Q@mail.gmail.com>
Date: Sat, 2 Nov 2024 17:11:54 -0700
From: John Ousterhout <ouster@...stanford.edu>
To: kernel test robot <lkp@...el.com>
Cc: netdev@...r.kernel.org, oe-kbuild-all@...ts.linux.dev
Subject: Re: [PATCH net-next 12/12] net: homa: create Makefile and Kconfig

I have made a stab at fixing all of the problems reported by the test
robot. However, it may take a few passes to figure exactly how to make
sparse happy...

-John-


On Tue, Oct 29, 2024 at 6:09 PM kernel test robot <lkp@...el.com> wrote:
>
> Hi John,
>
> kernel test robot noticed the following build warnings:
>
> [auto build test WARNING on net-next/main]
>
> url:    https://github.com/intel-lab-lkp/linux/commits/John-Ousterhout/net-homa-define-user-visible-API-for-Homa/20241029-095137
> base:   net-next/main
> patch link:    https://lore.kernel.org/r/20241028213541.1529-13-ouster%40cs.stanford.edu
> patch subject: [PATCH net-next 12/12] net: homa: create Makefile and Kconfig
> config: arc-randconfig-r132-20241029 (https://download.01.org/0day-ci/archive/20241030/202410300823.rFSVqCH5-lkp@intel.com/config)
> compiler: arc-elf-gcc (GCC) 13.2.0
> reproduce: (https://download.01.org/0day-ci/archive/20241030/202410300823.rFSVqCH5-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@...el.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202410300823.rFSVqCH5-lkp@intel.com/
>
> sparse warnings: (new ones prefixed by >>)
>    net/homa/homa_rpc.c: note: in included file:
> >> net/homa/homa_impl.h:605:13: sparse: sparse: restricted __be32 degrades to integer
>    net/homa/homa_rpc.c: note: in included file (through include/linux/smp.h, include/linux/lockdep.h, include/linux/spinlock.h, ...):
>    include/linux/list.h:83:21: sparse: sparse: self-comparison always evaluates to true
>    net/homa/homa_rpc.c:84:9: sparse: sparse: context imbalance in 'homa_rpc_new_client' - different lock contexts for basic block
>    include/linux/list.h:83:21: sparse: sparse: self-comparison always evaluates to true
>    net/homa/homa_rpc.c:104:17: sparse: sparse: context imbalance in 'homa_rpc_new_server' - wrong count at exit
>    net/homa/homa_rpc.c: note: in included file (through include/linux/rculist.h, include/linux/sched/signal.h, include/linux/ptrace.h, ...):
>    include/linux/rcupdate.h:881:9: sparse: sparse: context imbalance in 'homa_rpc_acked' - unexpected unlock
>    net/homa/homa_rpc.c: note: in included file (through include/linux/smp.h, include/linux/lockdep.h, include/linux/spinlock.h, ...):
>    include/linux/list.h:83:21: sparse: sparse: self-comparison always evaluates to true
>    net/homa/homa_rpc.c:235:6: sparse: sparse: context imbalance in 'homa_rpc_free' - different lock contexts for basic block
>    net/homa/homa_rpc.c:311:5: sparse: sparse: context imbalance in 'homa_rpc_reap' - wrong count at exit
>    net/homa/homa_rpc.c:448:17: sparse: sparse: context imbalance in 'homa_find_client_rpc' - wrong count at exit
>    net/homa/homa_rpc.c:474:17: sparse: sparse: context imbalance in 'homa_find_server_rpc' - wrong count at exit
> --
> >> net/homa/homa_sock.c:85:39: sparse: sparse: cast removes address space '__rcu' of expression
>    net/homa/homa_sock.c:91:31: sparse: sparse: cast removes address space '__rcu' of expression
>    net/homa/homa_sock.c:165:6: sparse: sparse: context imbalance in 'homa_sock_shutdown' - wrong count at exit
>    net/homa/homa_sock.c:243:5: sparse: sparse: context imbalance in 'homa_sock_bind' - different lock contexts for basic block
>    net/homa/homa_sock.c:312:6: sparse: sparse: context imbalance in 'homa_sock_lock_slow' - wrong count at exit
>    net/homa/homa_sock.c:326:6: sparse: sparse: context imbalance in 'homa_bucket_lock_slow' - wrong count at exit
>
> vim +605 net/homa/homa_impl.h
>
> 1416f12d4ea455 John Ousterhout 2024-10-28  595
> 1416f12d4ea455 John Ousterhout 2024-10-28  596  /**
> 1416f12d4ea455 John Ousterhout 2024-10-28  597   * Given an IPv4 address, return an equivalent IPv6 address (an IPv4-mapped
> 1416f12d4ea455 John Ousterhout 2024-10-28  598   * one)
> 1416f12d4ea455 John Ousterhout 2024-10-28  599   * @ip4: IPv4 address, in network byte order.
> 1416f12d4ea455 John Ousterhout 2024-10-28  600   */
> 1416f12d4ea455 John Ousterhout 2024-10-28  601  static inline struct in6_addr ipv4_to_ipv6(__be32 ip4)
> 1416f12d4ea455 John Ousterhout 2024-10-28  602  {
> 1416f12d4ea455 John Ousterhout 2024-10-28  603          struct in6_addr ret = {};
> 1416f12d4ea455 John Ousterhout 2024-10-28  604
> 1416f12d4ea455 John Ousterhout 2024-10-28 @605          if (ip4 == INADDR_ANY)
> 1416f12d4ea455 John Ousterhout 2024-10-28  606                  return in6addr_any;
> 1416f12d4ea455 John Ousterhout 2024-10-28  607          ret.in6_u.u6_addr32[2] = htonl(0xffff);
> 1416f12d4ea455 John Ousterhout 2024-10-28  608          ret.in6_u.u6_addr32[3] = ip4;
> 1416f12d4ea455 John Ousterhout 2024-10-28  609          return ret;
> 1416f12d4ea455 John Ousterhout 2024-10-28  610  }
> 1416f12d4ea455 John Ousterhout 2024-10-28  611
>
> --
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests/wiki