netdev - RE: Of ena auto

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b3df5db4bea6401095b908b3632bb09e@amazon.com>
Date: Sun, 3 Nov 2024 19:02:59 +0000
From: "Arinzon, David" <darinzon@...zon.com>
To: "Dr. David Alan Gilbert" <linux@...blig.org>, "Agroskin, Shay"
	<shayagr@...zon.com>, "Kiyanovski, Arthur" <akiyano@...zon.com>
CC: "Dagan, Noam" <ndagan@...zon.com>, "Bshara, Saeed" <saeedb@...zon.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: Of ena auto_polling

> Hi,
>   I noticed that commit:
> commit a4e262cde3cda4491ce666e7c5270954c4d926b9
> Author: Sameeh Jubran <sameehj@...zon.com>
> Date:   Mon Jun 3 17:43:25 2019 +0300
> 
>     net: ena: allow automatic fallback to polling mode
> 
> added a 'ena_com_set_admin_auto_polling_mode()' that's unused.
> Is that the intention?
> Because that then makes me wonder how
> admin_queue->auto_polling
> gets set, and then if the whole chunk is unused?
> 
> Thanks,
> 
> Dave
> --
>  -----Open up your eyes, open up your mind, open up your code -------
> / Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \
> \        dave @ treblig.org |                               | In Hex /
>  \ _________________________|_____ http://www.treblig.org
> |_______/

Hi Dave,
The auto polling mode was written as a fallback in case there are issues with interrupts,
it is currently not used by the ENA Linux driver, from Linux's perspective, it can be removed.