netdev - Re: [RFC net-next v01 1/1] net: hinic3: Add a driver for Huawei 3rd gen NIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <61c2a2bf-c39a-4629-b57d-8d6ecb264842@lunn.ch>
Date: Sun, 3 Nov 2024 22:19:24 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Gur Stavi <gur.stavi@...wei.com>
Cc: 'Jakub Kicinski' <kuba@...nel.org>,
	"Gongfan (Eric, Chip)" <gongfan1@...wei.com>,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
	Cai Huoqing <cai.huoqing@...ux.dev>,
	"Guoxin (D)" <guoxin09@...wei.com>,
	shenchenyang <shenchenyang1@...ilicon.com>,
	"zhoushuai (A)" <zhoushuai28@...wei.com>,
	"Wulike (Collin)" <wulike1@...wei.com>,
	"shijing (A)" <shijing34@...wei.com>,
	Meny Yossefi <meny.yossefi@...wei.com>
Subject: Re: [RFC net-next v01 1/1] net: hinic3: Add a driver for Huawei 3rd
 gen NIC

> To properly review (error prone) pause it would be better to remove it from
> initial submission and add it in a later dedicated submission.

Not really. It should be in a patch titled ethtool, so it is easy to
find. And since i've pointed out most drivers get it wrong, you will
assume you also have it wrong, assign a developer to go read the
discussion on the netdev list where i point out drivers which get it
wrong and what is the correct implementation, your developer will then
fixup your code if needed, and all i need to do is confirm you got it
right. Or shake my head and say despite the warning, it is still
wrong. 

	Andrew