netdev - Re: [RFC PATCH] dt-bindings: can: convert tcan4x5x.txt to DT schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5567d259-dc06-455e-9ec3-56af14db3706@kernel.org>
Date: Mon, 4 Nov 2024 11:40:09 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Marc Kleine-Budde <mkl@...gutronix.de>
Cc: Sean Nyekjaer <sean@...nix.com>,
 Vincent Mailhol <mailhol.vincent@...adoo.fr>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, linux-can@...r.kernel.org,
 netdev@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH] dt-bindings: can: convert tcan4x5x.txt to DT schema

On 04/11/2024 11:31, Marc Kleine-Budde wrote:
> On 04.11.2024 10:27:04, Krzysztof Kozlowski wrote:
>>> +properties:
>>> +  compatible:
>>> +    oneOf:
>>> +      - enum:
>>> +          - ti,tcan4552
>>> +          - ti,tcan4553
>>> +          - ti,tcan4x5x
>>
>> That's not really what old binding said.
>>
>> It said for example:
>> "ti,tcan4552", "ti,tcan4x5x"
>>
>> Which is not allowed above. You need list. Considering there are no
>> in-tree users of ti,tcan4x5x alone, I would allow only lists followed by
>> ti,tcan4x5x. IOW: disallow ti,tcan4x5x alone.
> 
> I'd like to keep the old binding.

Any reason why? It's against of bindings policies. If this was a new
binding, it would be a clear NAK, so here due to lack of user we can
make it correct.

> 
>> Mention this change to the binding in the commit message.
> 
> The tcan4x5x chip family has 2 registers for automatic detection of the
> chip variant. While the ID2 register of the tcan4550 is 0x0, the
> registers for the tcan4552 and tcan4553 contain 4552 and 4553
> respectively in ASCII.

This does not grant exception for wildcards. This only says that one
model should be used as fallback.

> 
> The driver was originally added for the tcan4550 chip, but currently
> only has a compatible for "ti,tcan4x5x".

That's not really related to discussion. We do not talk about changing
driver.

Best regards,
Krzysztof