netdev - RE: [Intel-wired-lan] [PATCH iwl-next v12 12/14] iavf: Implement checking DD desc field

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <SJ0PR11MB5865CBFF618777D1E36336EB8F512@SJ0PR11MB5865.namprd11.prod.outlook.com>
Date: Mon, 4 Nov 2024 11:05:07 +0000
From: "Romanowski, Rafal" <rafal.romanowski@...el.com>
To: "Polchlopek, Mateusz" <mateusz.polchlopek@...el.com>,
	"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "Polchlopek, Mateusz"
	<mateusz.polchlopek@...el.com>, "Drewek, Wojciech"
	<wojciech.drewek@...el.com>, Rahul Rameshbabu <rrameshbabu@...dia.com>, Simon
 Horman <horms@...nel.org>
Subject: RE: [Intel-wired-lan] [PATCH iwl-next v12 12/14] iavf: Implement
 checking DD desc field

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of
> Mateusz Polchlopek
> Sent: Tuesday, October 22, 2024 1:41 PM
> To: intel-wired-lan@...ts.osuosl.org
> Cc: netdev@...r.kernel.org; Polchlopek, Mateusz
> <mateusz.polchlopek@...el.com>; Drewek, Wojciech
> <wojciech.drewek@...el.com>; Rahul Rameshbabu
> <rrameshbabu@...dia.com>; Simon Horman <horms@...nel.org>
> Subject: [Intel-wired-lan] [PATCH iwl-next v12 12/14] iavf: Implement checking
> DD desc field
> 
> Rx timestamping introduced in PF driver caused the need of refactoring the VF
> driver mechanism to check packet fields.
> 
> The function to check errors in descriptor has been removed and from now only
> previously set struct fields are being checked. The field DD (descriptor done)
> needs to be checked at the very beginning, before extracting other fields.
> 
> Reviewed-by: Wojciech Drewek <wojciech.drewek@...el.com>
> Reviewed-by: Rahul Rameshbabu <rrameshbabu@...dia.com>
> Reviewed-by: Simon Horman <horms@...nel.org>
> Signed-off-by: Mateusz Polchlopek <mateusz.polchlopek@...el.com>
> ---
>  drivers/net/ethernet/intel/iavf/iavf_txrx.c | 54 ++++++++++++++++-----
> drivers/net/ethernet/intel/iavf/iavf_txrx.h | 16 ------
> drivers/net/ethernet/intel/iavf/iavf_type.h |  2 +
>  3 files changed, 43 insertions(+), 29 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/iavf/iavf_txrx.c
> b/drivers/net/ethernet/intel/iavf/iavf_txrx.c
> index 89b71509e521..283997b8a777 100644
> --- a/drivers/net/ethernet/intel/iavf/iavf_txrx.c
> +++ b/drivers/net/ethernet/intel/iavf/iavf_txrx.c
> @@ -9,6 +9,25 @@

Tested-by: Rafal Romanowski <rafal.romanowski@...el.com>