netdev - RE: [Intel-wired-lan] [PATCH iwl-next v12 14/14] iavf: add support for Rx timestamps to hotpath

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <SJ0PR11MB5865FE4484294C2FB8D34E348F512@SJ0PR11MB5865.namprd11.prod.outlook.com>
Date: Mon, 4 Nov 2024 11:06:02 +0000
From: "Romanowski, Rafal" <rafal.romanowski@...el.com>
To: "Polchlopek, Mateusz" <mateusz.polchlopek@...el.com>,
	"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "Keller, Jacob E"
	<jacob.e.keller@...el.com>, "Drewek, Wojciech" <wojciech.drewek@...el.com>,
	Rahul Rameshbabu <rrameshbabu@...dia.com>, Sunil Goutham
	<sgoutham@...vell.com>, Simon Horman <horms@...nel.org>, "Polchlopek,
 Mateusz" <mateusz.polchlopek@...el.com>
Subject: RE: [Intel-wired-lan] [PATCH iwl-next v12 14/14] iavf: add support
 for Rx timestamps to hotpath

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of
> Mateusz Polchlopek
> Sent: Tuesday, October 22, 2024 1:41 PM
> To: intel-wired-lan@...ts.osuosl.org
> Cc: netdev@...r.kernel.org; Keller, Jacob E <jacob.e.keller@...el.com>; Drewek,
> Wojciech <wojciech.drewek@...el.com>; Rahul Rameshbabu
> <rrameshbabu@...dia.com>; Sunil Goutham <sgoutham@...vell.com>; Simon
> Horman <horms@...nel.org>; Polchlopek, Mateusz
> <mateusz.polchlopek@...el.com>
> Subject: [Intel-wired-lan] [PATCH iwl-next v12 14/14] iavf: add support for Rx
> timestamps to hotpath
> 
> From: Jacob Keller <jacob.e.keller@...el.com>
> 
> Add support for receive timestamps to the Rx hotpath. This support only works
> when using the flexible descriptor format, so make sure that we request this
> format by default if we have receive timestamp support available in the PTP
> capabilities.
> 
> In order to report the timestamps to userspace, we need to perform timestamp
> extension. The Rx descriptor does actually contain the "40 bit" timestamp.
> However, upper 32 bits which contain nanoseconds are conveniently stored
> separately in the descriptor. We could extract the 32bits and lower 8 bits, then
> perform a bitwise OR to calculate the 40bit value. This makes no sense, because
> the timestamp extension algorithm would simply discard the lower 8 bits
> anyways.
> 
> Thus, implement timestamp extension as iavf_ptp_extend_32b_timestamp(), and
> extract and forward only the 32bits of nominal nanoseconds.
> 
> Signed-off-by: Jacob Keller <jacob.e.keller@...el.com>
> Reviewed-by: Wojciech Drewek <wojciech.drewek@...el.com>
> Reviewed-by: Rahul Rameshbabu <rrameshbabu@...dia.com>
> Reviewed-by: Sunil Goutham <sgoutham@...vell.com>
> Reviewed-by: Simon Horman <horms@...nel.org>
> Signed-off-by: Mateusz Polchlopek <mateusz.polchlopek@...el.com>
> ---
>  drivers/net/ethernet/intel/iavf/iavf_main.c |  9 +++
> drivers/net/ethernet/intel/iavf/iavf_ptp.c  | 61 +++++++++++++++++++++
> drivers/net/ethernet/intel/iavf/iavf_ptp.h  | 11 ++++
> drivers/net/ethernet/intel/iavf/iavf_txrx.c | 43 +++++++++++++++
> drivers/net/ethernet/intel/iavf/iavf_type.h |  1 +
>  5 files changed, 125 insertions(+)
> 
> diff --git a/drivers/net/ethernet/intel/iavf/iavf_main.c
> b/drivers/net/ethernet/intel/iavf/iavf_main.c
> index 1103c210b4e3..a25ceecf1ea7 100644
> --- a/drivers/net/ethernet/intel/iavf/iavf_main.c
> +++ b/drivers/net/ethernet/intel/iavf/iavf_main.c
> @@ -730,6 +730,15 @@ static u8 iavf_select_rx_desc_format(const struct

Tested-by: Rafal Romanowski <rafal.romanowski@...el.com>