netdev - Re: [PATCH net] Fix u32's systematic failure to free IDR entries for hnodes.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b08fb88f-129d-4e4a-8656-5f11334df300@gmail.com>
Date: Mon, 4 Nov 2024 21:26:59 +0100
From: Alexandre Ferrieux <alexandre.ferrieux@...il.com>
To: Pedro Tammela <pctammela@...atatu.com>,
 Alexandre Ferrieux <alexandre.ferrieux@...il.com>, edumazet@...gle.com
Cc: jhs@...atatu.com, xiyou.wangcong@...il.com, jiri@...nulli.us,
 netdev@...r.kernel.org
Subject: Re: [PATCH net] Fix u32's systematic failure to free IDR entries for
 hnodes.

On 04/11/2024 18:00, Pedro Tammela wrote:
>> 
>> Signed-off-by: Alexandre Ferrieux <alexandre.ferrieux@...nge.com>
> 
> SoB does not match sender, probably missing 'From:' tag

Due to dumb administrativia at my organization, I am compelled to post from my
personal gmail accout in order for my posts to be acceptable on this mailing
list; while I'd like to keep my official address in commit logs. Is it possible ?

> Also, this seems to deserve a 'Fixes:' tag as well

This would be the initial commit:

 ^1da177e4c3f4 (Linus Torvalds           2005-04-16 15:20:36 -0700   19)

Is that what you mean ?

> 'static inline' is discouraged in .c files

Why ?

It could have been a local macro, but an inline has (a bit) better type
checking. And I didn't want to add it to a .h that is included by many other
unrelated components, as it makes no sense to them. So, what is the recommendation ?