netdev - Re: [PATCH net] bnxt_en: ethtool: Fix ip[6] ntuple rule verification

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <319eb538-4b7c-45e9-b0ab-01d5ffdc097e@app.fastmail.com>
Date: Tue, 05 Nov 2024 08:46:26 +0900
From: "Daniel Xu" <dxu@...uu.xyz>
To: "Michael Chan" <michael.chan@...adcom.com>
Cc: "David Miller" <davem@...emloft.net>,
 "Eric Dumazet" <edumazet@...gle.com>, andrew+netdev@...n.ch,
 "Jakub Kicinski" <kuba@...nel.org>, vikas.gupta@...adcom.com,
 andrew.gospodarek@...adcom.com, "Paolo Abeni" <pabeni@...hat.com>,
 pavan.chebbi@...adcom.com, "Martin KaFai Lau" <martin.lau@...ux.dev>,
 netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
 "Kernel Team" <kernel-team@...a.com>
Subject: Re: [PATCH net] bnxt_en: ethtool: Fix ip[6] ntuple rule verification

Hi Michael,

On Tue, Nov 5, 2024, at 2:21 AM, Michael Chan wrote:
> On Fri, Nov 1, 2024 at 3:42 PM Daniel Xu <dxu@...uu.xyz> wrote:
>> On Fri, Nov 01, 2024 at 12:20:44PM GMT, Michael Chan wrote:
>> > Thanks for the patch.  I think the original author Vikas intended the
>> > user to do this for ip only filters:
>> >
>> > ethtool -N eth0 flow-type ip6 dst-ip $IP6 l4_proto 0xff context 1
>> >
>> > But your patch makes sense and simplifies the usage for the user.  I
>> > just need to check that FW can accept 0 for the ip_protocol field to
>> > mean wildcard when it receives the FW message to create the filter.
>> >
>> > I will reply when I get the answer from the FW team.  If FW requires
>> > 0xff, then we just need to make a small change to your patch.
>>
>> FWIW at least my HW/FW seems to behave correctly with my patch. I did
>> some quick tracing last night w/ a UDP traffic generator running to
>> confirm redirection occurs.
>>
> The FW team has confirmed that ip_protocol 0 will work as a wild card
> on all FW supporting this feature.  So the patch will work.
>
> But I think I want to eliminate the l4_proto 0xff usage.  It is
> non-standard and non-intuitive.  So we should only support l4_proto to
> be TCP, UDP, ICMP, or unspecified for any protocol.  Thanks.
>

Thanks for looking. I will send v3 that rolls up all the feedback
from this thread.

Thanks,
Daniel