netdev - Re: [PATCH net-next v1 1/1] nfc: mrvl: Don't use "proxy" headers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZyiA0Hx6z4hHqwe0@smile.fi.intel.com>
Date: Mon, 4 Nov 2024 10:07:44 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v1 1/1] nfc: mrvl: Don't use "proxy" headers

On Sat, Nov 02, 2024 at 09:00:04AM +0100, Krzysztof Kozlowski wrote:
> On 01/11/2024 09:39, Andy Shevchenko wrote:
> > Update header inclusions to follow IWYU (Include What You Use)
> > principle.

...

> > -#include <linux/module.h>
> >  #include <linux/delay.h>
> > -#include <linux/of_gpio.h>
> > +#include <linux/device.h>
> > +#include <linux/err.h>
> > +#include <linux/module.h>
> > +#include <linux/of.h>
> > +#include <linux/printk.h>
> 
> Do we really include printk?

Yes, we use it here.

> It's almost everywhere and pulled by kernel.h.

kernel.h shouldn't be considered at all, it's a mess which is on undergoing
cleaning up process.


> I assume you checked rest of the nfcmrvl files for similar cleanups, so
> anyway:
> 
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Thank you!

-- 
With Best Regards,
Andy Shevchenko