netdev - RE: [Intel-wired-lan] [iwl-next v6 2/9] ice: devlink PF MSI-X max and min parameter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ad5bf0e312d44737a18c076ab2990924@AcuMS.aculab.com>
Date: Mon, 4 Nov 2024 08:51:25 +0000
From: David Laight <David.Laight@...LAB.COM>
To: 'Michal Swiatkowski' <michal.swiatkowski@...ux.intel.com>, Michal Schmidt
	<mschmidt@...hat.com>
CC: "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"pawel.chmielewski@...el.com" <pawel.chmielewski@...el.com>,
	"sridhar.samudrala@...el.com" <sridhar.samudrala@...el.com>,
	"jacob.e.keller@...el.com" <jacob.e.keller@...el.com>,
	"pio.raczynski@...il.com" <pio.raczynski@...il.com>,
	"konrad.knitter@...el.com" <konrad.knitter@...el.com>,
	"marcin.szycik@...el.com" <marcin.szycik@...el.com>,
	"wojciech.drewek@...el.com" <wojciech.drewek@...el.com>,
	"nex.sw.ncis.nat.hpm.dev@...el.com" <nex.sw.ncis.nat.hpm.dev@...el.com>,
	"przemyslaw.kitszel@...el.com" <przemyslaw.kitszel@...el.com>,
	"jiri@...nulli.us" <jiri@...nulli.us>, "horms@...nel.org" <horms@...nel.org>
Subject: RE: [Intel-wired-lan] [iwl-next v6 2/9] ice: devlink PF MSI-X max and
 min parameter

From: Michal Swiatkowski
> Sent: 04 November 2024 07:03
...
> > The type of the devlink parameters msix_vec_per_pf_{min,max} is
> > specified as u32, so you must use value.vu32 everywhere you work with
> > them, not vu16.
> >
> 
> I will change it.

You also need a pretty good reason to use u16 anywhere at all.
Just because the domain of the value is small doesn't mean the
best type isn't [unsigned] int.

Any arithmetic (particularly on non x86) is likely to increase
the code size above any perceived data saving.

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)