netdev - Re: [PATCH 0/4] net: stmmac: dwmac-mediatek: Fix inverted logic for mediatek,mac-wol

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9a1ce320-e1ce-4d2f-a8d1-7680155ef71f@collabora.com>
Date: Mon, 4 Nov 2024 11:18:48 +0100
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
To: Nícolas F. R. A. Prado <nfraprado@...labora.com>,
 Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Matthias Brugger
 <matthias.bgg@...il.com>, Biao Huang <biao.huang@...iatek.com>,
 Alexandre Torgue <alexandre.torgue@...s.st.com>,
 Jose Abreu <joabreu@...opsys.com>,
 Maxime Coquelin <mcoquelin.stm32@...il.com>
Cc: kernel@...labora.com, netdev@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-mediatek@...ts.infradead.org, linux-stm32@...md-mailman.stormreply.com
Subject: Re: [PATCH 0/4] net: stmmac: dwmac-mediatek: Fix inverted logic for
 mediatek,mac-wol

Il 01/11/24 16:20, Nícolas F. R. A. Prado ha scritto:
> This series fixes the inverted handling of the mediatek,mac-wol DT
> property while keeping backward compatibility. It does so by introducing
> a new property on patch 1 and updating the driver to handle it on patch
> 2. Patch 3 adds this property on the Genio 700 EVK DT, where this issue
> was noticed, to get WOL working on that platform. Patch 4 adds the new
> property on all DTs with the MediaTek DWMAC ethernet node enabled
> and inverts the presence of mediatek,mac-wol to maintain the
> current behavior and have it match the description in the binding.
> 

Actually, I'm sure that all of these boards *do* need MAC WOL and *not* PHY WOL.

The only one I'm unsure about is MT2712, but that's an evaluation board and not
a retail product with "that kind of diffusion".

I think you can just fix the bug in the driver without getting new properties
and such. One commit, two lines.

Cheers,
Angelo

> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@...labora.com>
> ---
> Nícolas F. R. A. Prado (4):
>        net: dt-bindings: dwmac: Introduce mediatek,mac-wol-noninverted
>        net: stmmac: dwmac-mediatek: Handle non-inverted mediatek,mac-wol
>        arm64: dts: mediatek: mt8390-genio-700-evk: Enable ethernet MAC WOL
>        arm64: dts: mediatek: Add mediatek,mac-wol-noninverted to ethernet nodes
> 
>   Documentation/devicetree/bindings/net/mediatek-dwmac.yaml     | 11 +++++++++++
>   arch/arm64/boot/dts/mediatek/mt2712-evb.dts                   |  2 ++
>   arch/arm64/boot/dts/mediatek/mt8195-demo.dts                  |  2 ++
>   arch/arm64/boot/dts/mediatek/mt8390-genio-700-evk.dts         |  1 +
>   arch/arm64/boot/dts/mediatek/mt8395-genio-1200-evk.dts        |  2 +-
>   arch/arm64/boot/dts/mediatek/mt8395-kontron-3-5-sbc-i1200.dts |  2 ++
>   arch/arm64/boot/dts/mediatek/mt8395-radxa-nio-12l.dts         |  2 +-
>   drivers/net/ethernet/stmicro/stmmac/dwmac-mediatek.c          |  9 ++++++---
>   8 files changed, 26 insertions(+), 5 deletions(-)
> ---
> base-commit: c88416ba074a8913cf6d61b789dd834bbca6681c
> change-id: 20241101-mediatek-mac-wol-noninverted-198c6c404536
> 
> Best regards,