netdev - Re: [PATCH net-next 0/4] net: ucc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKxU2N_wxh+31VkZAAczVUUVt5duLv=yBj9zyLMDfoYGPq=G5Q@mail.gmail.com>
Date: Mon, 4 Nov 2024 17:35:08 -0800
From: Rosen Penev <rosenp@...il.com>
To: netdev@...r.kernel.org
Cc: Andrew Lunn <andrew+netdev@...n.ch>, maxime.chevallier@...tlin.com, 
	"David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, 
	"open list:FREESCALE QUICC ENGINE UCC ETHERNET DRIVER" <linuxppc-dev@...ts.ozlabs.org>, open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next 0/4] net: ucc_geth: devm cleanups

On Mon, Nov 4, 2024 at 1:01 PM Rosen Penev <rosenp@...il.com> wrote:
>
> Also added a small fix for NVMEM mac addresses.
>
> This was tested as working on a Watchguard T10 device.
>
> Rosen Penev (4):
>   net: ucc_geth: use devm for kmemdup
>   net: ucc_geth: use devm for alloc_etherdev
>   net: ucc_geth: use devm for register_netdev
>   net: ucc_geth: fix usage with NVMEM MAC address
oh this is interesting

_remove calls platform_get_drvdata but platform_set_drvdata never gets
called. I believe that means _remove is operating on a NULL pointer.
>
>  drivers/net/ethernet/freescale/ucc_geth.c | 34 ++++++++++-------------
>  1 file changed, 14 insertions(+), 20 deletions(-)
>
> --
> 2.47.0
>