netdev - Re: [PATCH net-next] phonet: do not call synchronize_rcu() from phonet_route

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANn89iK0mAk__j32b6yOUJsDtM0EDgymgoKi0P8o+ZEf_YVbbg@mail.gmail.com>
Date: Tue, 5 Nov 2024 13:11:29 +0100
From: Eric Dumazet <edumazet@...gle.com>
To: Rémi Denis-Courmont <remi@...lab.net>
Cc: "David S . Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, 
	Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org, eric.dumazet@...il.com, 
	syzbot <syzkaller@...glegroups.com>, Kuniyuki Iwashima <kuniyu@...zon.com>, 
	Remi Denis-Courmont <courmisch@...il.com>
Subject: Re: [PATCH net-next] phonet: do not call synchronize_rcu() from phonet_route_del()

On Tue, Nov 5, 2024 at 12:05 PM Rémi Denis-Courmont <remi@...lab.net> wrote:
>

> Synchronising after sending notifications sounds a bit iffy. Whatever a given notification is about should be fully committed so we don't create a user-visible race here.

This is fine, the notification sends the ifindex, after the route is
effectively removed.

Fact that the device is held a bit longer than before should be an
improvement, or just a nop.

However, doing the dev_put() after synchronize_rcu() is probably better.