netdev - Re: [PATCH ipsec-next v13 15/15] xfrm: iptfs: add tracepoint functionality

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202411052231.OM2TTHhn-lkp@intel.com>
Date: Tue, 5 Nov 2024 23:06:00 +0800
From: kernel test robot <lkp@...el.com>
To: Christian Hopps <chopps@...pps.org>, devel@...ux-ipsec.org
Cc: oe-kbuild-all@...ts.linux.dev,
	Steffen Klassert <steffen.klassert@...unet.com>,
	netdev@...r.kernel.org, Florian Westphal <fw@...len.de>,
	Sabrina Dubroca <sd@...asysnail.net>,
	Simon Horman <horms@...nel.org>, Antony Antony <antony@...nome.org>,
	Christian Hopps <chopps@...pps.org>
Subject: Re: [PATCH ipsec-next v13 15/15] xfrm: iptfs: add tracepoint
 functionality

Hi Christian,

kernel test robot noticed the following build warnings:

[auto build test WARNING on klassert-ipsec-next/master]
[also build test WARNING on next-20241105]
[cannot apply to klassert-ipsec/master netfilter-nf/main linus/master nf-next/master v6.12-rc6]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Christian-Hopps/xfrm-config-add-CONFIG_XFRM_IPTFS/20241105-164740
base:   https://git.kernel.org/pub/scm/linux/kernel/git/klassert/ipsec-next.git master
patch link:    https://lore.kernel.org/r/20241105083759.2172771-16-chopps%40chopps.org
patch subject: [PATCH ipsec-next v13 15/15] xfrm: iptfs: add tracepoint functionality
config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20241105/202411052231.OM2TTHhn-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 14.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241105/202411052231.OM2TTHhn-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202411052231.OM2TTHhn-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> net/xfrm/xfrm_iptfs.c:194:12: warning: '__trace_ip_proto_seq' defined but not used [-Wunused-function]
     194 | static u32 __trace_ip_proto_seq(struct iphdr *iph)
         |            ^~~~~~~~~~~~~~~~~~~~
>> net/xfrm/xfrm_iptfs.c:187:12: warning: '__trace_ip_proto' defined but not used [-Wunused-function]
     187 | static u32 __trace_ip_proto(struct iphdr *iph)
         |            ^~~~~~~~~~~~~~~~

Kconfig warnings: (for reference only)
   WARNING: unmet direct dependencies detected for GET_FREE_REGION
   Depends on [n]: SPARSEMEM [=n]
   Selected by [y]:
   - RESOURCE_KUNIT_TEST [=y] && RUNTIME_TESTING_MENU [=y] && KUNIT [=y]


vim +/__trace_ip_proto_seq +194 net/xfrm/xfrm_iptfs.c

   186	
 > 187	static u32 __trace_ip_proto(struct iphdr *iph)
   188	{
   189		if (iph->version == 4)
   190			return iph->protocol;
   191		return ((struct ipv6hdr *)iph)->nexthdr;
   192	}
   193	
 > 194	static u32 __trace_ip_proto_seq(struct iphdr *iph)
   195	{
   196		void *nexthdr;
   197		u32 protocol = 0;
   198	
   199		if (iph->version == 4) {
   200			nexthdr = (void *)(iph + 1);
   201			protocol = iph->protocol;
   202		} else if (iph->version == 6) {
   203			nexthdr = (void *)(((struct ipv6hdr *)(iph)) + 1);
   204			protocol = ((struct ipv6hdr *)(iph))->nexthdr;
   205		}
   206		switch (protocol) {
   207		case IPPROTO_ICMP:
   208			return ntohs(((struct icmphdr *)nexthdr)->un.echo.sequence);
   209		case IPPROTO_ICMPV6:
   210			return ntohs(((struct icmp6hdr *)nexthdr)->icmp6_sequence);
   211		case IPPROTO_TCP:
   212			return ntohl(((struct tcphdr *)nexthdr)->seq);
   213		case IPPROTO_UDP:
   214			return ntohs(((struct udphdr *)nexthdr)->source);
   215		default:
   216			return 0;
   217		}
   218	}
   219	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki