netdev - Re: [PATCH net-next v2 2/2] netlink: specs: Add a spec for FIB rule management

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <m2ldxxvgwy.fsf@gmail.com>
Date: Tue, 05 Nov 2024 15:28:29 +0000
From: Donald Hunter <donald.hunter@...il.com>
To: Ido Schimmel <idosch@...dia.com>
Cc: netdev@...r.kernel.org,  Jakub Kicinski <kuba@...nel.org>,  "David S.
 Miller" <davem@...emloft.net>,  Eric Dumazet <edumazet@...gle.com>,  Paolo
 Abeni <pabeni@...hat.com>,  Simon Horman <horms@...nel.org>,
  donald.hunter@...hat.com,  Stanislav Fomichev <sdf@...ichev.me>
Subject: Re: [PATCH net-next v2 2/2] netlink: specs: Add a spec for FIB rule
 management

Ido Schimmel <idosch@...dia.com> writes:

> On Tue, Nov 05, 2024 at 12:28:31PM +0000, Donald Hunter wrote:
>
> Reviewed-by: Ido Schimmel <idosch@...dia.com>
>
> One question below (didn't notice it before)
>
> [...]
>
>> +    -
>> +      name: getrule
>> +      doc: Dump all FIB rules
>> +      attribute-set: fib-rule-attrs
>> +      dump:
>> +        request:
>> +          value: 34
>> +          attributes:
>> +            - nsid
>
> What is the significance of 'nsid' here?

Hmm, looks like a couple of lines I need to remove.

Thanks for catching this!