netdev - Re: RE: [PATCH v3 net-next 3/3] net: ena: Add PHC documentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <91932534-7309-4650-b4c8-1bfe61579b50@nvidia.com>
Date: Tue, 5 Nov 2024 18:16:24 +0200
From: Gal Pressman <gal@...dia.com>
To: "Arinzon, David" <darinzon@...zon.com>, Jakub Kicinski <kuba@...nel.org>
Cc: David Miller <davem@...emloft.net>,
 "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
 Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
 Richard Cochran <richardcochran@...il.com>,
 "Woodhouse, David" <dwmw@...zon.co.uk>, "Machulsky, Zorik"
 <zorik@...zon.com>, "Matushevsky, Alexander" <matua@...zon.com>,
 "Bshara, Saeed" <saeedb@...zon.com>, "Wilson, Matt" <msw@...zon.com>,
 "Liguori, Anthony" <aliguori@...zon.com>, "Bshara, Nafea"
 <nafea@...zon.com>, "Schmeilin, Evgeny" <evgenys@...zon.com>,
 "Belgazal, Netanel" <netanel@...zon.com>, "Saidi, Ali"
 <alisaidi@...zon.com>, "Herrenschmidt, Benjamin" <benh@...zon.com>,
 "Kiyanovski, Arthur" <akiyano@...zon.com>, "Dagan, Noam"
 <ndagan@...zon.com>, "Bernstein, Amit" <amitbern@...zon.com>,
 "Agroskin, Shay" <shayagr@...zon.com>, "Abboud, Osama"
 <osamaabb@...zon.com>, "Ostrovsky, Evgeny" <evostrov@...zon.com>,
 "Tabachnik, Ofir" <ofirt@...zon.com>,
 "Machnikowski, Maciek" <maciek@...hnikowski.net>,
 Rahul Rameshbabu <rrameshbabu@...dia.com>
Subject: Re: RE: [PATCH v3 net-next 3/3] net: ena: Add PHC documentation

On 05/11/2024 12:52, Arinzon, David wrote:
>>> +=================
>> ======================================================
>>> +**phc_cnt**         Number of successful retrieved timestamps (below
>> expire timeout).
>>> +**phc_exp**         Number of expired retrieved timestamps (above
>> expire timeout).
>>> +**phc_skp**         Number of skipped get time attempts (during block
>> period).
>>> +**phc_err**         Number of failed get time attempts (entering into block
>> state).
>>> +=================
>> ======================================================
>>
>> I seem to recall we had an unpleasant conversation about using standard
>> stats recently. Please tell me where you looked to check if Linux has standard
>> stats for packet timestamping. We need to add the right info there.
>> --
>> pw-bot: cr
> 
> Hi Jakub,
> 
> Just wanted to clarify that this feature and the associated documentation are specifically intended for reading a HW timestamp,
> not for TX/RX packet timestamping.
> We reviewed similar drivers that support HW timestamping via `gettime64` and `gettimex64` APIs,
> and we couldn't identify any that capture or report statistics related to reading a HW timestamp.
> Let us know if further details would be helpful.

David, did you consider Rahul's recent timestamping stats API?
0e9c127729be ("ethtool: add interface to read Tx hardware timestamping
statistics")