netdev - Re: [PATCH net-next 1/7] net: skb_reset_mac_len() must check if mac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZypcWB421XqVaiYS@LQ3V64L9R2>
Date: Tue, 5 Nov 2024 09:56:40 -0800
From: Joe Damato <jdamato@...tly.com>
To: Eric Dumazet <edumazet@...gle.com>
Cc: "David S . Miller" <davem@...emloft.net>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	netdev@...r.kernel.org, eric.dumazet@...il.com,
	En-Wei Wu <en-wei.wu@...onical.com>
Subject: Re: [PATCH net-next 1/7] net: skb_reset_mac_len() must check if
 mac_header was set

On Tue, Nov 05, 2024 at 05:43:57PM +0000, Eric Dumazet wrote:
> Recent discussions show that skb_reset_mac_len() should be more careful.
> 
> We expect the MAC header being set.
> 
> If not, clear skb->mac_len and fire a warning for CONFIG_DEBUG_NET=y builds.
> 
> If after investigations we find that not having a MAC header was okay,
> we can remove the warning.
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Link: https://lore.kernel.org/netdev/CANn89iJZGH+yEfJxfPWa3Hm7jxb-aeY2Up4HufmLMnVuQXt38A@mail.gmail.com/T/
> Cc: En-Wei Wu <en-wei.wu@...onical.com>
> ---
>  include/linux/skbuff.h | 17 +++++++++++------
>  1 file changed, 11 insertions(+), 6 deletions(-)

Reviewed-by: Joe Damato <jdamato@...tly.com>