netdev - Re: [PATCH net-next] net: phy: aquantia: Add mdix config and reporting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c69eb0c307346bce51ccb3f990a26d79e942c9e2.camel@alliedtelesis.co.nz>
Date: Wed, 6 Nov 2024 00:01:33 +0000
From: Paul Davey <Paul.Davey@...iedtelesis.co.nz>
To: "andrew@...n.ch" <andrew@...n.ch>
CC: "daniel@...rotopia.org" <daniel@...rotopia.org>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next] net: phy: aquantia: Add mdix config and
 reporting

On Fri, 2024-10-18 at 19:20 +0200, Andrew Lunn wrote:
> 
> > When I was wondering if mdix_ctrl being set to ETH_TP_MDI_AUTO
> > should
> > be rejected if auto-negotiation is disabled I meant for this
> > specific
> > PHY driver as it definitely does not appear to perform the Auto
> > MDI/MDI-X resolution so if the wiring/cabling between and/or config
> > on
> > the link partner does not match the default (MDI I think for the
> > AQR)
> > then the link will not establish.
> 
> Well, as you say, 1000Base-T needs autoneg, so there is no need to
> reject ETH_TP_MDI_AUTO for that link mode and above.
> 
> It seems like for lower speeds, ETH_TP_MDI_AUTO could work without
> autoneg. So to me, this validation is not a core feature, but per
> PHY.
> Please feel free to implement it for this PHY.
> 
Having briefly tried it the _phy_state_machine code does not like
phy_config_aneg returning errors, so I will leave the code as is.

I will submit a v2 patch soon with the other requested changes.

Thanks,
Paul