netdev - Re: [PATCH net v2] net/smc: Fix lookup of netdev by using ib_device_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241106122541.GD5006@unreal>
Date: Wed, 6 Nov 2024 14:25:41 +0200
From: Leon Romanovsky <leon@...nel.org>
To: Wenjia Zhang <wenjia@...ux.ibm.com>
Cc: David Miller <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>,
	Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
	netdev@...r.kernel.org, linux-s390@...r.kernel.org,
	linux-rdma@...r.kernel.org, Simon Horman <horms@...nel.org>,
	Michael Guralnik <michaelgur@...dia.com>,
	Heiko Carstens <hca@...ux.ibm.com>,
	Wen Gu <guwen@...ux.alibaba.com>,
	"D. Wythe" <alibuda@...ux.alibaba.com>,
	Tony Lu <tonylu@...ux.alibaba.com>,
	Jan Karcher <jaka@...ux.ibm.com>, Gerd Bayer <gbayer@...ux.ibm.com>,
	Alexandra Winter <wintera@...ux.ibm.com>,
	Halil Pasic <pasic@...ux.ibm.com>,
	Nils Hoppmann <niho@...ux.ibm.com>,
	Niklas Schnell <schnelle@...ux.ibm.com>,
	Thorsten Winkler <twinkler@...ux.ibm.com>,
	Karsten Graul <kgraul@...ux.ibm.com>,
	Stefan Raspl <raspl@...ux.ibm.com>, Aswin K <aswin@...ux.ibm.com>,
	Dust Li <dust.li@...ux.alibaba.com>,
	Zhu Yanjun <yanjun.zhu@...ux.dev>
Subject: Re: [PATCH net v2] net/smc: Fix lookup of netdev by using
 ib_device_get_netdev()

On Wed, Nov 06, 2024 at 09:26:12AM +0100, Wenjia Zhang wrote:
> The SMC-R variant of the SMC protocol used direct call to function
> ib_device_ops.get_netdev() to lookup netdev. As we used mlx5 device
> driver to run SMC-R, it failed to find a device, because in mlx5_ib the
> internal net device management for retrieving net devices was replaced
> by a common interface ib_device_get_netdev() in commit 8d159eb2117b
> ("RDMA/mlx5: Use IB set_netdev and get_netdev functions").
> 
> Since such direct accesses to the internal net device management is not
> recommended at all, update the SMC-R code to use proper API
> ib_device_get_netdev().
> 
> Fixes: 54903572c23c ("net/smc: allow pnetid-less configuration")
> Reported-by: Aswin K <aswin@...ux.ibm.com>
> Reviewed-by: Gerd Bayer <gbayer@...ux.ibm.com>
> Reviewed-by: Halil Pasic <pasic@...ux.ibm.com>
> Reviewed-by: Simon Horman <horms@...nel.org>
> Reviewed-by: Dust Li <dust.li@...ux.alibaba.com>
> Reviewed-by: Wen Gu <guwen@...ux.alibaba.com>
> Reviewed-by: Zhu Yanjun <yanjun.zhu@...ux.dev>
> Reviewed-by: D. Wythe <alibuda@...ux.alibaba.com>
> Signed-off-by: Wenjia Zhang <wenjia@...ux.ibm.com>
> ---
>  net/smc/smc_ib.c   | 8 ++------
>  net/smc/smc_pnet.c | 4 +---
>  2 files changed, 3 insertions(+), 9 deletions(-)
> 

Thanks,
Reviewed-by: Leon Romanovsky <leonro@...dia.com>