netdev - Re: [PATCH net v2] Fix u32's systematic failure to free IDR entries for hnodes.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANn89i+Lu_2q7_onZcrZhqu6NY9=rxAi9jopZW053dRH_7qojQ@mail.gmail.com>
Date: Wed, 6 Nov 2024 15:19:17 +0100
From: Eric Dumazet <edumazet@...gle.com>
To: Alexandre Ferrieux <alexandre.ferrieux@...il.com>
Cc: jhs@...atatu.com, xiyou.wangcong@...il.com, jiri@...nulli.us, 
	alexandre.ferrieux@...nge.com, netdev@...r.kernel.org
Subject: Re: [PATCH net v2] Fix u32's systematic failure to free IDR entries
 for hnodes.

On Wed, Nov 6, 2024 at 2:54 PM Alexandre Ferrieux
<alexandre.ferrieux@...il.com> wrote:
>
> To generate hnode handles (in gen_new_htid()), u32 uses IDR and
> encodes the returned small integer into a structured 32-bit
> word. Unfortunately, at disposal time, the needed decoding
> is not done. As a result, idr_remove() fails, and the IDR
> fills up. Since its size is 2048, the following script ends up
> with "Filter already exists":
>
>   tc filter add dev myve $FILTER1
>   tc filter add dev myve $FILTER2
>   for i in {1..2048}
>   do
>     echo $i
>     tc filter del dev myve $FILTER2
>     tc filter add dev myve $FILTER2
>   done
>
> This patch adds the missing decoding logic for handles that
> deserve it.
>
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> Signed-off-by: Alexandre Ferrieux <alexandre.ferrieux@...nge.com>
> ---
> v2: use u32 type in handle encoder/decoder

Note that the patch title should be more like

[PATCH v2 net] net: sched: cls_u32: Fix u32's systematic failure to
free IDR entries for hnodes.

ie include some tags to identify the subsystem [1]

Reviewed-by: Eric Dumazet <edumazet@...gle.com>

[1] One way to get some common patterns is to look at the output of

git log --oneline net/sched/cls_u32.c