netdev - Re: [PATCHv2 net-next] net: sfc: use ethtool string helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d6d6a813-762f-b5a1-6a61-1cea24ba6618@gmail.com>
Date: Wed, 6 Nov 2024 20:14:05 +0000
From: Edward Cree <ecree.xilinx@...il.com>
To: Rosen Penev <rosenp@...il.com>, netdev@...r.kernel.org
Cc: Martin Habets <habetsm.xilinx@...il.com>,
 Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Richard Cochran <richardcochran@...il.com>,
 Alexei Starovoitov <ast@...nel.org>, Daniel Borkmann <daniel@...earbox.net>,
 Jesper Dangaard Brouer <hawk@...nel.org>,
 John Fastabend <john.fastabend@...il.com>,
 "open list:SFC NETWORK DRIVER" <linux-net-drivers@....com>,
 open list <linux-kernel@...r.kernel.org>,
 "open list:XDP (eXpress Data Path):Keyword:(?:b|_)xdp(?:b|_)"
 <bpf@...r.kernel.org>
Subject: Re: [PATCHv2 net-next] net: sfc: use ethtool string helpers

On 05/11/2024 23:18, Rosen Penev wrote:
> The latter is the preferred way to copy ethtool strings.
> 
> Avoids manually incrementing the pointer. Cleans up the code quite well.
> 
> Signed-off-by: Rosen Penev <rosenp@...il.com>

Acked-by: Edward Cree <ecree.xilinx@...il.com>

I was initially curious why we still needed the 'n_stats++;' bits,
 for the record it's for .get_sset_count().  (If you end up needing
 to respin for any reason, perhaps make that explicit in the commit
 message.)