netdev - Re: [External] Re: [PATCH v2 bpf] bpf: Add sk_is_inet and IS_ICSK check in tls_sw_has_ctx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <de982cf0-45f5-46bc-91a7-e0f1d7745686@bytedance.com>
Date: Tue, 5 Nov 2024 16:27:49 -0800
From: Zijian Zhang <zijianzhang@...edance.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: bpf@...r.kernel.org, borisp@...dia.com, john.fastabend@...il.com,
 davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com,
 horms@...nel.org, daniel@...earbox.net, ast@...nel.org,
 stfomichev@...il.com, netdev@...r.kernel.org
Subject: Re: [External] Re: [PATCH v2 bpf] bpf: Add sk_is_inet and IS_ICSK
 check in tls_sw_has_ctx_tx/rx

On 11/3/24 12:15 PM, Jakub Kicinski wrote:
> On Wed, 30 Oct 2024 16:18:55 +0000 zijianzhang@...edance.com wrote:
>> As the introduction of the support for vsock and unix sockets in sockmap,
>> tls_sw_has_ctx_tx/rx cannot presume the socket passed in must be IS_ICSK.
>> vsock and af_unix sockets have vsock_sock and unix_sock instead of
>> inet_connection_sock. For these sockets, tls_get_ctx may return an invalid
>> pointer and cause page fault in function tls_sw_ctx_rx.
> 
> Since it's touching TLS code:
> 
> Acked-by: Jakub Kicinski <kuba@...nel.org>
> 
> I wonder if we should move these helpers to skmsg or such, since only
> bpf uses them.
> 

Agree, skmsg.h seems a better place for these two helpers.