netdev - [PATCH] net/mlx5e: Report rx_discards_phy via rx_missed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20241106064015.4118-1-laoar.shao@gmail.com>
Date: Wed,  6 Nov 2024 14:40:15 +0800
From: Yafang Shao <laoar.shao@...il.com>
To: saeedm@...dia.com,
	tariqt@...dia.com,
	leon@...nel.org
Cc: netdev@...r.kernel.org,
	linux-rdma@...r.kernel.org,
	Yafang Shao <laoar.shao@...il.com>
Subject: [PATCH] net/mlx5e: Report rx_discards_phy via rx_missed_errors

We observed a high number of rx_discards_phy events on some servers when
running `ethtool -S`. However, this important counter is not currently
reflected in the /proc/net/dev statistics file, making it challenging to
monitor effectively.

Since rx_missed_errors represents packets dropped due to buffer exhaustion,
it makes sense to include rx_discards_phy in this counter to enhance
monitoring visibility. This change will help administrators track these
events more effectively through standard interfaces.

Signed-off-by: Yafang Shao <laoar.shao@...il.com>
Cc: Saeed Mahameed <saeedm@...dia.com>
Cc: Tariq Toukan <tariqt@...dia.com>
Cc: Leon Romanovsky <leon@...nel.org>
---
 drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c
index 6f686fabed44..42c1b791a74c 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c
@@ -3903,7 +3903,8 @@ mlx5e_get_stats(struct net_device *dev, struct rtnl_link_stats64 *stats)
 		mlx5e_fold_sw_stats64(priv, stats);
 	}
 
-	stats->rx_missed_errors = priv->stats.qcnt.rx_out_of_buffer;
+	stats->rx_missed_errors = priv->stats.qcnt.rx_out_of_buffer +
+				  PPORT_2863_GET(pstats, if_in_discards);
 
 	stats->rx_length_errors =
 		PPORT_802_3_GET(pstats, a_in_range_length_errors) +
-- 
2.30.1 (Apple Git-130)