netdev - Re: [PATCH net-next] eth: fbnic: Add PCIe hardware statistics

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241106160958.6d287fd8@kernel.org>
Date: Wed, 6 Nov 2024 16:09:58 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Andrew Lunn <andrew@...n.ch>
Cc: Bjorn Helgaas <helgaas@...nel.org>, Leon Romanovsky <leon@...nel.org>,
 Sanman Pradhan <sanman.p211993@...il.com>, Bjorn Helgaas
 <bhelgaas@...gle.com>, netdev@...r.kernel.org, alexanderduyck@...com,
 kernel-team@...a.com, davem@...emloft.net, edumazet@...gle.com,
 pabeni@...hat.com, horms@...nel.org, corbet@....net,
 mohsin.bashr@...il.com, sanmanpradhan@...a.com, andrew+netdev@...n.ch,
 vadim.fedorenko@...ux.dev, jdamato@...tly.com, sdf@...ichev.me,
 linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-pci@...r.kernel.org
Subject: Re: [PATCH net-next] eth: fbnic: Add PCIe hardware statistics

On Wed, 6 Nov 2024 18:36:16 +0100 Andrew Lunn wrote:
> > How would this be done in the PCI core?  As far as I can tell, all
> > these registers are device-specific and live in some device BAR.  
> 
> Is this a licences PCIe core?
> 
> Could the same statistics appear in other devices which licence the
> same core? Maybe this needs pulling out into a helper?

The core is licensed but I believe the _USER in the defines names means
the stats sit in the integration logic not the licensed IP. I could be
wrong.

> If this is true, other uses of this core might not be networking
> hardware, so ethtool -S would not be the best interfaces. Then they
> should appear in debugfs?

I tried to push back on adding PCIe config to network tooling,
and nobody listened. Look at all the PCI stuff in devlink params.
Some vendors dump PCIe signal integrity into ethtool -S