[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20241107112339.GJ5006@unreal>
Date: Thu, 7 Nov 2024 13:23:39 +0200
From: Leon Romanovsky <leon@...nel.org>
To: Sanman Pradhan <sanman.p211993@...il.com>
Cc: netdev@...r.kernel.org, alexanderduyck@...com, kuba@...nel.org,
kernel-team@...a.com, davem@...emloft.net, edumazet@...gle.com,
pabeni@...hat.com, horms@...nel.org, corbet@....net,
mohsin.bashr@...il.com, sanmanpradhan@...a.com,
andrew+netdev@...n.ch, vadim.fedorenko@...ux.dev,
jdamato@...tly.com, sdf@...ichev.me, linux-doc@...r.kernel.org,
linux-kernel@...r.kernel.org, Bjorn Helgaas <helgaas@...nel.org>,
linux-pci@...r.kernel.org
Subject: Re: [PATCH net-next v2] eth: fbnic: Add PCIe hardware statistics
On Wed, Nov 06, 2024 at 06:05:55PM -0800, Sanman Pradhan wrote:
> Add PCIe hardware statistics support to the fbnic driver. These stats
> provide insight into PCIe transaction performance and error conditions.
>
> Which includes, read/write and completion TLP counts and DWORD counts and
> debug counters for tag, completion credit and NP credit exhaustion
>
> The stats are exposed via ethtool and can be used to monitor PCIe
> performance and debug PCIe issues.
>
> Signed-off-by: Sanman Pradhan <sanman.p211993@...il.com>
> ---
> v1:
> - https://patchwork.kernel.org/project/netdevbpf/patch/20241106002625.1857904-1-sanman.p211993@gmail.com/
> - Removed unnecessary code blocks
> - Rephrased the commit message
> ---
> .../device_drivers/ethernet/meta/fbnic.rst | 27 +++++
> drivers/net/ethernet/meta/fbnic/fbnic_csr.h | 39 ++++++
> .../net/ethernet/meta/fbnic/fbnic_ethtool.c | 77 +++++++++++-
> .../net/ethernet/meta/fbnic/fbnic_hw_stats.c | 114 ++++++++++++++++++
> .../net/ethernet/meta/fbnic/fbnic_hw_stats.h | 12 ++
> .../net/ethernet/meta/fbnic/fbnic_netdev.c | 3 +
> drivers/net/ethernet/meta/fbnic/fbnic_pci.c | 2 +
> 7 files changed, 272 insertions(+), 2 deletions(-)
You completely ignored discussion and participants in v1 about
providing general solution which is applicable to all PCI devices
in the world.
Thanks
Powered by blists - more mailing lists