netdev - RE: [Intel-wired-lan] [PATCH net-next] ice: Fix NULL pointer dereference in switchdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <PH0PR11MB50139E81DD6E5309FB04D0C1965C2@PH0PR11MB5013.namprd11.prod.outlook.com>
Date: Thu, 7 Nov 2024 12:08:29 +0000
From: "Buvaneswaran, Sujai" <sujai.buvaneswaran@...el.com>
To: "Drewek, Wojciech" <wojciech.drewek@...el.com>,
	"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [Intel-wired-lan] [PATCH net-next] ice: Fix NULL pointer
 dereference in switchdev

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of
> Wojciech Drewek
> Sent: Tuesday, October 29, 2024 3:13 PM
> To: intel-wired-lan@...ts.osuosl.org
> Cc: netdev@...r.kernel.org
> Subject: [Intel-wired-lan] [PATCH net-next] ice: Fix NULL pointer dereference
> in switchdev
> 
> Commit ("virtchnl: support queue rate limit and quanta size
> configuration") introduced new virtchnl ops:
> - get_qos_caps
> - cfg_q_bw
> - cfg_q_quanta
> 
> New ops were added to ice_virtchnl_dflt_ops but not to the
> ice_virtchnl_repr_ops. Because of that, if we get one of those messages in
> switchdev mode we end up with NULL pointer dereference:
> 
> [ 1199.794701] BUG: kernel NULL pointer dereference, address:
> 0000000000000000 [ 1199.794804] Workqueue: ice ice_service_task [ice] [
> 1199.794878] RIP: 0010:0x0 [ 1199.795027] Call Trace:
> [ 1199.795033]  <TASK>
> [ 1199.795039]  ? __die+0x20/0x70
> [ 1199.795051]  ? page_fault_oops+0x140/0x520 [ 1199.795064]  ?
> exc_page_fault+0x7e/0x270 [ 1199.795074]  ?
> asm_exc_page_fault+0x22/0x30 [ 1199.795086]
> ice_vc_process_vf_msg+0x6e5/0xd30 [ice] [ 1199.795165]
> __ice_clean_ctrlq+0x734/0x9d0 [ice] [ 1199.795207]
> ice_service_task+0xccf/0x12b0 [ice] [ 1199.795248]
> process_one_work+0x21a/0x620 [ 1199.795260]
> worker_thread+0x18d/0x330 [ 1199.795269]  ?
> __pfx_worker_thread+0x10/0x10 [ 1199.795279]  kthread+0xec/0x120 [
> 1199.795288]  ? __pfx_kthread+0x10/0x10 [ 1199.795296]
> ret_from_fork+0x2d/0x50 [ 1199.795305]  ? __pfx_kthread+0x10/0x10 [
> 1199.795312]  ret_from_fork_asm+0x1a/0x30 [ 1199.795323]  </TASK>
> 
> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>
> Reviewed-by: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>
> Signed-off-by: Wojciech Drewek <wojciech.drewek@...el.com>
> ---
>  drivers/net/ethernet/intel/ice/ice_virtchnl.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
Tested-by: Sujai Buvaneswaran <sujai.buvaneswaran@...el.com>