netdev - Re: [PATCH net-next v3 2/3] net: support SO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89i+FHaLLgk_WUg1AXXF3EwL3uVF_s5NdP3jwZj5-KAaekQ@mail.gmail.com>
Date: Thu, 7 Nov 2024 14:50:53 +0100
From: Eric Dumazet <edumazet@...gle.com>
To: Anna Emese Nyiri <annaemesenyiri@...il.com>
Cc: netdev@...r.kernel.org, fejes@....elte.hu, kuba@...nel.org, 
	pabeni@...hat.com, willemdebruijn.kernel@...il.com
Subject: Re: [PATCH net-next v3 2/3] net: support SO_PRIORITY cmsg

On Thu, Nov 7, 2024 at 2:23 PM Anna Emese Nyiri
<annaemesenyiri@...il.com> wrote:
>
> The Linux socket API currently allows setting SO_PRIORITY at the
> socket level, applying a uniform priority to all packets sent through
> that socket. The exception to this is IP_TOS, when the priority value
> is calculated during the handling of
> ancillary data, as implemented in commit <f02db315b8d88>
> ("ipv4: IP_TOS and IP_TTL can be specified as ancillary data").
> However, this is a computed
> value, and there is currently no mechanism to set a custom priority
> via control messages prior to this patch.
>
> According to this pacth, if SO_PRIORITY is specified as ancillary data,
> the packet is sent with the priority value set through
> sockc->priority, overriding the socket-level values
> set via the traditional setsockopt() method. This is analogous to
> the existing support for SO_MARK, as implemented in commit
> <c6af0c227a22> ("ip: support SO_MARK cmsg").
>
> Suggested-by: Ferenc Fejes <fejes@....elte.hu>
> Signed-off-by: Anna Emese Nyiri <annaemesenyiri@...il.com>

Reviewed-by: Eric Dumazet <edumazet@...gle.com>