netdev - Re: [PATCH net v3] net: sched: cls_u32: Fix u32's systematic failure to free IDR entries for hnodes.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM0EoMknpWa-GapPyWZzXhzaDe6xBb7rtOovTk6Dpd2X=acknA@mail.gmail.com>
Date: Thu, 7 Nov 2024 09:47:05 -0500
From: Jamal Hadi Salim <jhs@...atatu.com>
To: Alexandre Ferrieux <alexandre.ferrieux@...il.com>
Cc: edumazet@...gle.com, xiyou.wangcong@...il.com, jiri@...nulli.us, 
	alexandre.ferrieux@...nge.com, netdev@...r.kernel.org
Subject: Re: [PATCH net v3] net: sched: cls_u32: Fix u32's systematic failure
 to free IDR entries for hnodes.

On Thu, Nov 7, 2024 at 9:45 AM Jamal Hadi Salim <jhs@...atatu.com> wrote:
>
> Hi,
>
> On Wed, Nov 6, 2024 at 9:32 AM Alexandre Ferrieux
> <alexandre.ferrieux@...il.com> wrote:
> >
> > To generate hnode handles (in gen_new_htid()), u32 uses IDR and
> > encodes the returned small integer into a structured 32-bit
> > word. Unfortunately, at disposal time, the needed decoding
> > is not done. As a result, idr_remove() fails, and the IDR
> > fills up. Since its size is 2048, the following script ends up
> > with "Filter already exists":
> >
> >   tc filter add dev myve $FILTER1
> >   tc filter add dev myve $FILTER2
> >   for i in {1..2048}
> >   do
> >     echo $i
> >     tc filter del dev myve $FILTER2
> >     tc filter add dev myve $FILTER2
> >   done
> >
> > This patch adds the missing decoding logic for handles that
> > deserve it.
> >
> > Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> > Signed-off-by: Alexandre Ferrieux <alexandre.ferrieux@...nge.com>
>
> I'd like to take a closer look at this - just tied up with something
> at the moment. Give me a day or so.
> Did you run tdc tests after your patch?

Also, for hero status points, consider submitting a tdc test case.

cheers,
jamal