netdev - RE: [Intel-wired-lan] [PATCH iwl-net v2] i40e: Fix handling changed priv flags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CYYPR11MB8429A6C6306EB6B09F1169CCBD5C2@CYYPR11MB8429.namprd11.prod.outlook.com>
Date: Thu, 7 Nov 2024 15:16:03 +0000
From: "Pucha, HimasekharX Reddy" <himasekharx.reddy.pucha@...el.com>
To: "pegro@...iks.de" <pegro@...iks.de>, "intel-wired-lan@...ts.osuosl.org"
	<intel-wired-lan@...ts.osuosl.org>, Paul Menzel <pmenzel@...gen.mpg.de>,
	"Nguyen, Anthony L" <anthony.l.nguyen@...el.com>, "Kitszel, Przemyslaw"
	<przemyslaw.kitszel@...el.com>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [Intel-wired-lan] [PATCH iwl-net v2] i40e: Fix handling changed
 priv flags

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of pegro@...iks.de
> Sent: 30 October 2024 22:52
> To: intel-wired-lan@...ts.osuosl.org; Paul Menzel <pmenzel@...gen.mpg.de>; Nguyen, Anthony L <anthony.l.nguyen@...el.com>; Kitszel, Przemyslaw <przemyslaw.kitszel@...el.com>
> Cc: netdev@...r.kernel.org; Peter Große <pegro@...iks.de>
> Subject: [Intel-wired-lan] [PATCH iwl-net v2] i40e: Fix handling changed priv flags
>
> From: Peter Große <pegro@...iks.de>
>
> After assembling the new private flags on a PF, the operation to determine the changed flags uses the wrong bitmaps. Instead of xor-ing orig_flags with new_flags, it uses the still unchanged pf->flags, thus changed_flags is always 0.
>
> Fix it by using the correct bitmaps.
>
> The issue was discovered while debugging why disabling source pruning stopped working with release 6.7. Although the new flags will be copied to
> pf->flags later on in that function, disabling source pruning requires
> a reset of the PF, which was skipped due to this bug.
>
> Disabling source pruning:
> $ sudo ethtool --set-priv-flags eno1 disable-source-pruning on $ sudo ethtool --show-priv-flags eno1 Private flags for eno1:
> MFP                   : off
> total-port-shutdown   : off
> LinkPolling           : off
> flow-director-atr     : on
> veb-stats             : off
> hw-atr-eviction       : off
> link-down-on-close    : off
> legacy-rx             : off
> disable-source-pruning: on
> disable-fw-lldp       : off
> rs-fec                : off
> base-r-fec            : off
> vf-vlan-pruning       : off
>
> Regarding reproducing:
>
> I observed the issue with a rather complicated lab setup, where
>  * two VLAN interfaces are created on eno1
>  * each with a different MAC address assigned
>  * each moved into a separate namespace
>  * both VLANs are bridged externally, so they form a single layer 2 network
>
> The external bridge is done via a channel emulator adding packet loss and delay and the application in the namespaces tries to send/receive traffic and measure the performance. Sender and receiver are > separated by namespaces, yet the network card "sees its own traffic" send back to it.
> To make that work, source pruning has to be disabled.
>
> Fixes: 70756d0a4727 ("i40e: Use DECLARE_BITMAP for flags and hw_features fields in i40e_pf")
> Signed-off-by: Peter Große <pegro@...iks.de>
> ---
>  drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>

Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha@...el.com> (A Contingent worker at Intel)