netdev - Re: [PATCH net-next] eth: fbnic: Add PCIe hardware statistics

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241107074009.5712809a@kernel.org>
Date: Thu, 7 Nov 2024 07:40:09 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Leon Romanovsky <leon@...nel.org>
Cc: Vadim Fedorenko <vadim.fedorenko@...ux.dev>, Andrew Lunn
 <andrew@...n.ch>, Bjorn Helgaas <helgaas@...nel.org>, Sanman Pradhan
 <sanman.p211993@...il.com>, Bjorn Helgaas <bhelgaas@...gle.com>,
 netdev@...r.kernel.org, alexanderduyck@...com, kernel-team@...a.com,
 davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com,
 horms@...nel.org, corbet@....net, mohsin.bashr@...il.com,
 sanmanpradhan@...a.com, andrew+netdev@...n.ch, jdamato@...tly.com,
 sdf@...ichev.me, linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-pci@...r.kernel.org
Subject: Re: [PATCH net-next] eth: fbnic: Add PCIe hardware statistics

On Thu, 7 Nov 2024 14:03:57 +0200 Leon Romanovsky wrote:
> > [root@...t ~]# ethtool -i eth0 | grep driver
> > driver: mlx5_core
> > [root@...t ~]# ethtool -S eth0 | grep pci
> >      rx_pci_signal_integrity: 1
> >      tx_pci_signal_integrity: 1471
> >      outbound_pci_stalled_rd: 0
> >      outbound_pci_stalled_wr: 0
> >      outbound_pci_stalled_rd_events: 0
> >      outbound_pci_stalled_wr_events: 0
> > 
> > Isn't it a PCIe statistics?  
> 
> I didn't do full archaeological research and stopped at 2017 there these
> counters were updated to use new API, but it looks like they there from
> stone age.
> 
> It was a mistake to put it there and they should be moved to PCI core
> together with other hundreds debug counters which ConnectX devices have
> but don't expose yet.

Whatever hand-waving you do now, it's impossible to take you seriously
where the device driver of which you are a maintainer does the same
thing. And your direction going forward for PCIe debug, AFAIU, is the
proprietary fwctl stuff. Please stop.