netdev - Re: [PATCH net] ipmr: Fix access to mfc_cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241107-lumpy-newt-from-venus-c61cb2@leitao>
Date: Thu, 7 Nov 2024 09:55:59 -0800
From: Breno Leitao <leitao@...ian.org>
To: Eric Dumazet <edumazet@...gle.com>
Cc: "David S. Miller" <davem@...emloft.net>,
	David Ahern <dsahern@...nel.org>, Jakub Kicinski <kuba@...nel.org>,
	Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>,
	David Ahern <dsahern@...il.com>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, kernel-team@...a.com
Subject: Re: [PATCH net] ipmr: Fix access to mfc_cache_list without lock held

Hello Eric,

On Thu, Nov 07, 2024 at 03:04:19PM +0100, Eric Dumazet wrote:
> > Do you mean that, execute the dump operation without holding the RTNL,
> > thus, relying solely on RCU?
> 
> Right, you might have seen patches adding RTNL_FLAG_DUMP_UNLOCKED in
> some places ?
> 
> More patches are welcomed, in net-next.

Sure. Do you have any explict driver that you need help, and no one is
looking at?

> > Clarifying next steps: Would you like me to review/test and submit, or
> > are you planning to send it officially?
> 
> For this kind of feedback, I am usually expecting you to send a new
> version (after waiting one day,
> maybe other reviewers have something to say)

Thanks. I am testing it now, and I will submit the patch tomorrow if no one
else have any further comments.