[<prev] [next>] [day] [month] [year] [list]
Message-ID: <20241107183431.1270772-1-jeroendb@google.com>
Date: Thu, 7 Nov 2024 10:34:31 -0800
From: Jeroen de Borst <jeroendb@...gle.com>
To: netdev@...r.kernel.org
Cc: davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
stable@...r.kernel.org, pabeni@...hat.com, jeroendb@...gle.com,
pkaligineedi@...gle.com, shailend@...gle.com, andrew+netdev@...n.ch,
willemb@...gle.com, hramamurthy@...gle.com, ziweixiao@...gle.com
Subject: [PATCH net] gve: Flow steering trigger reset only for timeout error
From: Ziwei Xiao <ziweixiao@...gle.com>
When configuring flow steering rules, the driver is currently going
through a reset for all errors from the device. Instead, the driver
should only reset when there's a timeout error from the device.
Fixes: 57718b60df9b ("gve: Add flow steering adminq commands")
Cc: stable@...r.kernel.org
Signed-off-by: Ziwei Xiao <ziweixiao@...gle.com>
Reviewed-by: Harshitha Ramamurthy <hramamurthy@...gle.com>
---
drivers/net/ethernet/google/gve/gve_adminq.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/google/gve/gve_adminq.c b/drivers/net/ethernet/google/gve/gve_adminq.c
index e44e8b139633..060e0e674938 100644
--- a/drivers/net/ethernet/google/gve/gve_adminq.c
+++ b/drivers/net/ethernet/google/gve/gve_adminq.c
@@ -1248,10 +1248,10 @@ gve_adminq_configure_flow_rule(struct gve_priv *priv,
sizeof(struct gve_adminq_configure_flow_rule),
flow_rule_cmd);
- if (err) {
+ if (err == -ETIME) {
dev_err(&priv->pdev->dev, "Timeout to configure the flow rule, trigger reset");
gve_reset(priv, true);
- } else {
+ } else if (!err) {
priv->flow_rules_cache.rules_cache_synced = false;
}
--
2.47.0.277.g8800431eea-goog
Powered by blists - more mailing lists