netdev - Re: [PATCH net 4/4] virtio/vsock: Put vsock_connected_sockets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <14fbd6da-9ef5-400c-9dde-afff3d2c7525@rbox.co>
Date: Thu, 7 Nov 2024 22:04:03 +0100
From: Michal Luczaj <mhal@...x.co>
To: Stefano Garzarella <sgarzare@...hat.com>
Cc: Stefan Hajnoczi <stefanha@...hat.com>, "Michael S. Tsirkin"
 <mst@...hat.com>, Jason Wang <jasowang@...hat.com>,
 Xuan Zhuo <xuanzhuo@...ux.alibaba.com>, Eugenio Pérez
 <eperezma@...hat.com>, "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>,
 Jia He <justin.he@....com>, Arseniy Krasnov <avkrasnov@...utedevices.com>,
 Dmitry Torokhov <dtor@...are.com>, Andy King <acking@...are.com>,
 George Zhang <georgezhang@...are.com>, kvm@...r.kernel.org,
 virtualization@...ts.linux.dev, netdev@...r.kernel.org
Subject: Re: [PATCH net 4/4] virtio/vsock: Put vsock_connected_sockets_vsk()
 to use

On 11/7/24 11:22, Stefano Garzarella wrote:
> On Wed, Nov 06, 2024 at 06:51:21PM +0100, Michal Luczaj wrote:
>> Macro vsock_connected_sockets_vsk() has been unused since its introduction.
>> Instead of removing it, utilise it in vsock_insert_connected() where it's
>> been open-coded.
>>
>> No functional change intended.
>>
>> Fixes: d021c344051a ("VSOCK: Introduce VM Sockets")
> 
> This is not a fix, so please remove the Fixes tag, we don't need to 
> backport this patch in stable branches.
> 
> Also in this case this is not related at all with virtio transport, so 
> please remove `virtio` from the commit title.
> 
> In addition maybe you can remove this patch from this series, and send 
> it to net-next.
> ...

Right, I get it. Just to be clear: are such small (and non-functional)
cleanups welcomed coming by themselves?

Thanks,
Michal