netdev - Re: [PATCH v2 2/2] net: arc: rockchip: fix emac mdio node support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d28eee82-7fb4-4dda-9d23-53434c76de17@lunn.ch>
Date: Thu, 7 Nov 2024 04:05:38 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Andy Yan <andyshrk@....com>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, david.wu@...k-chips.com,
	Johan Jonker <jbx6244@...il.com>,
	Andy Yan <andy.yan@...k-chips.com>
Subject: Re: [PATCH v2 2/2] net: arc: rockchip: fix emac mdio node support

On Wed, Nov 06, 2024 at 05:50:02PM -0800, Jakub Kicinski wrote:
> On Mon,  4 Nov 2024 21:01:39 +0800 Andy Yan wrote:
> > From: Johan Jonker <jbx6244@...il.com>
> > 
> > The binding emac_rockchip.txt is converted to YAML.
> > Changed against the original binding is an added MDIO subnode.
> > This make the driver failed to find the PHY, and given the 'mdio
> > has invalid PHY address' it is probably looking in the wrong node.
> > Fix emac_mdio.c so that it can handle both old and new
> > device trees.
> 
> Andrew, looks good?

The MDIO patch looks correct. I cannot say anything about the DMA
mapping.

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew