netdev - Re: [PATCH net-next v2 5/8] net: ip_gre: Add netns

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABAhCOSyG6sTWfDfoYDCbiXesDbGiWYFrK4OGi+3zFgO-CZPxA@mail.gmail.com>
Date: Fri, 8 Nov 2024 14:44:37 +0800
From: Xiao Liang <shaw.leon@...il.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Eric Dumazet <edumazet@...gle.com>, netdev@...r.kernel.org, 
	linux-kselftest@...r.kernel.org, Kuniyuki Iwashima <kuniyu@...zon.com>, 
	"David S. Miller" <davem@...emloft.net>, David Ahern <dsahern@...nel.org>, 
	Paolo Abeni <pabeni@...hat.com>, Ido Schimmel <idosch@...dia.com>, 
	Andrew Lunn <andrew+netdev@...n.ch>, Simon Horman <horms@...nel.org>, 
	Donald Hunter <donald.hunter@...il.com>, Shuah Khan <shuah@...nel.org>, 
	Jiri Pirko <jiri@...nulli.us>, Hangbin Liu <liuhangbin@...il.com>
Subject: Re: [PATCH net-next v2 5/8] net: ip_gre: Add netns_atomic module parameter

On Fri, Nov 8, 2024 at 12:04 PM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Fri, 8 Nov 2024 00:53:55 +0800 Xiao Liang wrote:
> > IMO, this is about driver capability, not about user requests.
>
> The bit is a driver capability, that's fine. But the question was how
> to achieve backward compatibility. A flag in user request shifts the
> responsibility of ensuring all services are compatible to whoever
> spawns the interfaces. Which will probably be some network management
> daemon.

OK. So I think we can change the driver capability indicator in rtnl_ops
to a tristate field, say, "linkns_support".
If it is
  - not supported, then keep the old behavior
  - supported (vlan, macvlan, etc.), then change to the new behavior
  - compat-mode (ip_tunnel), default to old behavior and can be changed
    via an IFLA flag.
Is this reasonable?

> > BTW, I didn't find what's going on with module parameters, is there
> > any documentation?
>
> Not sure if there is documentation, but module params are quite painful
> to work with. Main reason is that they are global and not namespace
> aware. Plus developers usually default to making them read only, which
> means they practically speaking have to be configured at boot.

Understood, thanks.