netdev - Re: [PATCH] net/mlx5e: Report rx_discards_phy via rx_missed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALOAHbCPDFs1D_XxoTmPushq70unz6UDn978Ati2sMV4fZ_MHg@mail.gmail.com>
Date: Fri, 8 Nov 2024 16:37:38 +0800
From: Yafang Shao <laoar.shao@...il.com>
To: Gal Pressman <gal@...dia.com>
Cc: Tariq Toukan <ttoukan.linux@...il.com>, saeedm@...dia.com, tariqt@...dia.com, 
	leon@...nel.org, netdev@...r.kernel.org, linux-rdma@...r.kernel.org
Subject: Re: [PATCH] net/mlx5e: Report rx_discards_phy via rx_missed_errors

On Thu, Nov 7, 2024 at 3:23 AM Gal Pressman <gal@...dia.com> wrote:
>
> On 06/11/2024 13:49, Yafang Shao wrote:
> > On Wed, Nov 6, 2024 at 5:56 PM Tariq Toukan <ttoukan.linux@...il.com> wrote:
> >>
> >>
> >>
> >> On 06/11/2024 8:40, Yafang Shao wrote:
> >>> We observed a high number of rx_discards_phy events on some servers when
> >>> running `ethtool -S`. However, this important counter is not currently
> >>> reflected in the /proc/net/dev statistics file, making it challenging to
> >>> monitor effectively.
> >>>
> >>> Since rx_missed_errors represents packets dropped due to buffer exhaustion,
> >>> it makes sense to include rx_discards_phy in this counter to enhance
> >>> monitoring visibility. This change will help administrators track these
> >>> events more effectively through standard interfaces.
> >>>
> >>
> >> Hi,
> >>
> >> Thanks for your patch.
> >>
> >> It's a matter of interpretation...
> >> The documentation in
> >> Documentation/ABI/testing/sysfs-class-net-statistics refers to the
> >> driver for the exact meaning.
>
> I think this documentation is outdated, a more recent one is in if_link.h:

Should we sync the documentation in if_link.h with
Documentation/ABI/testing/sysfs-class-net-statistics?

-- 
Regards
Yafang