netdev - Re: drivers/net/ethernet/freescale/ucc_geth.c:2454:64: sparse: sparse: incorrect type in argument 1 (different address spaces)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdYQ6Pfn_Y7FJh7MV2Mb8etDXFCJEUrgq=c3JDxkSPOndA@mail.gmail.com>
Date: Fri, 8 Nov 2024 12:41:17 +0100
From: Linus Walleij <linus.walleij@...aro.org>
To: Christophe Leroy <christophe.leroy@...roup.eu>
Cc: kernel test robot <lkp@...el.com>, 
	"linuxppc-dev@...ts.ozlabs.org list" <linuxppc-dev@...ts.ozlabs.org>, netdev <netdev@...r.kernel.org>, 
	Stanislav Kinsburskii <stanislav.kinsburskii@...il.com>, oe-kbuild-all@...ts.linux.dev, 
	linux-kernel@...r.kernel.org, Michael Ellerman <mpe@...erman.id.au>
Subject: Re: drivers/net/ethernet/freescale/ucc_geth.c:2454:64: sparse:
 sparse: incorrect type in argument 1 (different address spaces)

On Fri, Nov 8, 2024 at 11:30 AM Christophe Leroy
<christophe.leroy@...roup.eu> wrote:


> The problem is the __be16 in the function prototype.
>
>         set_mac_addr(&p_82xx_addr_filt->taddr.h, p_enet_addr);
>
> p_82xx_addr_filt->taddr.h is a u16
> and out_be16() expects a u16*
>
> So the following fixes the above warnings:

Ah you are right of course, thanks! :)

Let's wait to the big rework you mentioned to land and I will try
to remember to revisit this in the v6.13 kernel cycle.

Yours,
Linus Walleij