netdev - Re: [PATCH] net: ipv6: fix the address length for net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zy4fA07kgV3o4Xmn@emanuele-al>
Date: Fri, 8 Nov 2024 15:24:03 +0100
From: Emanuele Santini <emanuele.santini.88@...il.com>
To: Guillaume Nault <gnault@...hat.com>
Cc: netdev@...r.kernel.org, yoshfuji@...ux-ipv6.org, friedrich@...age.de,
	kuba@...nel.org, davem@...emloft.net, pabeni@...hat.com,
	dsahern@...nel.org
Subject: Re: [PATCH] net: ipv6: fix the address length for net_device on a
 GRE tunnel

I'm talking about the ip6gre. I agree that setting the hardware address to 0 is appropriate.
However, in the ip6gre_tunnel_setup function, the perm_addr field of net_device is 
currently assigned a random Ethernet address:

        dev->flags |= IFF_NOARP;
       - dev->addr_len = sizeof(struct in6_addr);
       + dev->addr_len = ETH_ALEN;
        netif_keep_dst(dev);
        /* This perm addr will be used as interface identifier by IPv6 */
        dev->addr_assign_type = NET_ADDR_RANDOM;
        eth_random_addr(dev->perm_addr);

maybe this is not a valid justification to set addr_len to ETH_ALEN.

I will make a review setting addr_len to 0, and will resubmit the patch after successful testing.